[Pkg-xfce-devel] Comments regarding xfce4-whiskermenu-plugin_1.1.1-1_amd64.changes

Yves-Alexis Perez corsac at debian.org
Fri Nov 8 14:53:23 UTC 2013


On Fri, 2013-11-08 at 14:13 +0000, Gergely Nagy wrote:
> Hi!
> 
> While going through your xfce4-whiskermenu-plugin upload, I noticed a
> few things which you may want to correct in a future upload:
> 
> * In debian/control, the last line is: "applications that you’ve
>   launched from it."
> 
>   Where the "you've" is with a funny unicode char instead of the usual
>   apostrophe.

It's U+2019 RIGHT SINGLE QUOTATION MARK. Policy recommends control files
to be valid UTF-8 so I don't think it's a problem. I'm not sure we
really *need* that unicode character though, it's not like if a single
quote can't be used (and if we really want to use unicode, I guess we
should still use an apostrophe char :)

> 
> * You include the CREDITS file in the binary package, which has no
>   useful information (d/copyright already covers it)

Yeah, dh_installdocs likes it :)
> 
> * You may wish to install the upstream NEWS file not as additional
>   documentation, but as the upstream changelog. You can override the
>   dh_installchangelog target to accomplish this.
> 
> 
Good point.

Jackson, can you take care of that?
-- 
Yves-Alexis
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-xfce-devel/attachments/20131108/69e7a924/attachment.sig>


More information about the Pkg-xfce-devel mailing list