[Pkg-xfce-devel] Bug#819039: xfce4-panel: Unnecessary manual call to ldconfig in postinst

[Niels Thykier]

Package: xfce4-panel
Version: 4.12.0-3
Severity: minor

Hi,

There is a manual call to ldconfig in the postinst script of the
xfce4-panel package.  This is unnecessary for two reasons:

 * debhelper added one automatically as well (see [1])
 * we are migrating to use triggers now for this case[2].

AFAICT, if you drop the manual ldconfig and remove the (now obsolete)
"rm_conffile" calls (inserted via a debian/<pkg>.maintscripts) then
xfce4-panel will not even need a postinst at all.  In fact, it would
have no maintainer scripts at all! :)

Should there be a case in the future where you need to invoke
ldconfig but debhelper is not realising it, you can instead insert:

  activate-noawait ldconfig

in your triggers file.

Thanks,
~Niels

[1]
"""
if [ "$1" = "configure" ]; then
        # Run ldconfig to update shared library system
        ldconfig
fi

# Automatically added by dh_makeshlibs
if [ "$1" = "configure" ]; then
        ldconfig
fi
"""

[2] https://lists.debian.org/debian-glibc/2015/08/msg00056.html