Bug#478991: vorbis-tools: ogg123 hangs and takes 100% of the cpu when outputting to a pipe that has been closed.

[David Caldwell]

Package: vorbis-tools
Version: 1.2.0-1
Severity: normal
Tags: patch


My test is:

  ./ogg123 -d wav -f - test.ogg | less

then press q to quit less. Ogg123 will hang and start taking 100% of
the CPU. The only way to stop it is "kill -9".

I have 2 patches that fix the problem:

  Patch #1: stop-eating-my-cpu.patch:

      This fixes the main hanging/cpu spinning problem.


  Patch #2: dont-decode-after-pipe-closes.patch:

      This adds a return value to buffer_submit_data() so that ogg123
    knows when the buffer has shut down due to an error. Without this
    it doesn't hang, but it continues to decode the input even though
    there's no place to write it to.

I have attempted to submit these patches to the upstream mailing
list. We'll see if they go through.

-David

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.24-1-686 (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/bash

Versions of packages vorbis-tools depends on:
ii  libao2                0.8.8-4            Cross Platform Audio Output Librar
ii  libc6                 2.7-10             GNU C Library: Shared libraries
ii  libcurl3-gnutls       7.18.0-1+b1        Multi-protocol file transfer libra
ii  libflac8              1.2.1-1.2          Free Lossless Audio Codec - runtim
ii  libkrb53              1.6.dfsg.3~beta1-4 MIT Kerberos runtime libraries
ii  libogg0               1.1.3-3            Ogg Bitstream Library
ii  libspeex1             1.1.12-3           The Speex Speech Codec
ii  libvorbis0a           1.2.0.dfsg-3       The Vorbis General Audio Compressi
ii  libvorbisenc2         1.2.0.dfsg-3       The Vorbis General Audio Compressi
ii  libvorbisfile3        1.2.0.dfsg-3       The Vorbis General Audio Compressi

vorbis-tools recommends no packages.

-- no debconf information
-------------- next part --------------
A non-text attachment was scrubbed...
Name: stop-eating-my-cpu.patch
Type: text/x-diff
Size: 1067 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-xiph-maint/attachments/20080501/abe76f6e/attachment.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dont-decode-after-pipe-closes.patch
Type: text/x-diff
Size: 2628 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-xiph-maint/attachments/20080501/abe76f6e/attachment-0001.patch