Bug#547223: libvorbis: ov_fopen should have const qualifier for char *path

[Kumar Appaiah]

tags 547223 + wontfix
thanks


On Thu, Sep 17, 2009 at 03:11:25PM -0500, Kumar Appaiah wrote:
> As can clearly be seen, char *path is used merely to open the file
> f. Since fopen requires only a const char * (it doesn't muck around
> with the path variable), ov_fopen should also have no business in
> modifying the path variable. Therefore, I'd request that you change
> the declaration of ov_fopen to:
> 
> int ov_fopen(const char *path,OggVorbis_File *vf);
> 
> to be more "correct" in terms of C style.

Upstream (rightly) acknowledged the problem, and said that they would
consider fixing it when they could afford an API breakage. So, I take
the liberty to mark it as wontfix here; please feel free to handle the
bug in a different manner if you feel this is not appropriate.

Thanks!

Kumar
-- 
I touch God in my song
as the hill touched the far-away sea
with its waterfall.
- Rabindranath Tagore (Fireflies, 1928)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-xiph-maint/attachments/20100324/0eeb9dda/attachment.pgp>