My plan for libvorbis towards Jessie

[Petter Reinholdtsen]

On Thu, Oct 23, 2014 at 02:08:50PM -0700, Ralph Giles wrote:
> On 2014-10-23 1:41 PM, Petter Reinholdtsen wrote:
> > After looking at the changes to libvorbis 1.3.4 compared to version
> > 1.3.2 currently in Debian, and noticing header file changes that
> > looked like they would cause ABI changes
> 
> Can you be specific as to what you're worried about? We try to make
> point releases compatible.

The same I said in another thread, that a header file changed type
from long to char.  These are the changes according to diffstat
between tags upstream/1.3.2 upstream/1.3.4 in git, excluding the
Makefiles and the doc/ directory:

 CHANGES                                        |   11 
 aclocal.m4                                     | 2723 +++---
 compile                                        |  241 
 config.guess                                   |  526 -
 config.h.in                                    |    6 
 config.sub                                     |  317 
 configure                                      |11072 ++++++++++++-------------
 configure.ac                                   |   18 
 depcomp                                        |  344 
 install-sh                                     |  534 -
 lib/block.c                                    |   12 
 lib/books/coupled/res_books_51.h               |  873 +
 lib/books/coupled/res_books_stereo.h           | 1130 +-
 lib/books/floor/floor_books.h                  |  390 
 lib/books/uncoupled/res_books_uncoupled.h      |  878 -
 lib/codebook.c                                 |   21 
 lib/codebook.h                                 |   16 
 lib/floor0.c                                   |   10 
 lib/floor1.c                                   |    7 
 lib/info.c                                     |   12 
 lib/modes/residue_44p51.h                      |    2 
 lib/modes/setup_44p51.h                        |    2 
 lib/os.h                                       |    6 
 lib/psy.c                                      |   15 
 lib/res0.c                                     |   54 
 lib/sharedbook.c                               |    4 
 lib/vorbisfile.c                               |   20 
 lib/window.c                                   |    3 
 lib/window.h                                   |    4 
 libvorbis.spec                                 |    2 
 ltmain.sh                                      | 4038 +++++----
 missing                                        |  145 
 test/test.c                                    |    2 
 test/util.c                                    |    2 
 test/util.h                                    |    2 
 test/write_read.c                              |    2 
 test/write_read.h                              |    2 
 vorbis.pc.in                                   |    5 
 vorbisenc.pc.in                                |    2 
 vorbisfile.pc.in                               |    2 
 vq/bookutil.c                                  |    8 
 vq/huffbuild.c                                 |    8 
 win32/VS2008/libvorbis/libvorbis_static.vcproj | 1313 ++

Several of the changes in the lib/ directory change the size of
structures and function signature of functions.  I am unsure about the
effect of library clients.  Other changes just add 'const', which is
not affecting the ABI in C as far I as know, but the changes from long
to char worries me.  If packages require rebuild to keep working, we
do not have time for that before saturday and the resting time before
the freeze. :)

-- 
Happy hacking
Petter Reinholdtsen