Bug#775983: oggenc: low --resample rate -> double free or corruption

Petter Reinholdtsen pere at hungry.com
Sun Sep 27 08:59:18 UTC 2015


I asked for comments on the #xiph IRC channel, and got these comments:

<mark4o> 500 Hz is a really low sample rate for audio
<OmniMancer> would anyone ever use 500Hz for actual Audio? or are they
  likely recoding some other signal?
<TD-Linux> I can't think of a use case. but it shouldn't crash
<OmniMancer> well yes, crashing is bad :/
<erikd> if vorbis can't handle really low sample rates it should
  validate its inputs and reject them
<mark4o> it's not vorbis itself it's the resampler
<erikd> its the resampler that crashing?
<mark4o> the code in oggenc that calls the resampler apparently
<mark4o> which looks like it was rewritten in opusenc, maybe it can be
  copied from there, not sure
<OmniMancer> I am glad that atleast in FLAC sample rate is just metadata
:)
<mark4o> it is in vorbis also, but oggenc has an option to resample it
  first; not sure why
<OmniMancer> vorbis is lossy and uses frequency space transforms though?
<mark4o> yes
<OmniMancer> so the sample rate could affect the result of coding?
<mark4o> I'm pretty sure it affects at least frame durations, but I'm
  not a vorbis expert.

Perhaps something to investigate?

-- 
Happy hacking
Petter Reinholdtsen



More information about the pkg-xiph-maint mailing list