Is oggvideotools completely broken now

Petter Reinholdtsen pere at hungry.com
Tue Aug 16 07:29:04 UTC 2016


Hi Jörn.  Very good to hear from you. :)

[Jörn Seger]
> Good news, I uploaded some new code to SVN (that does not have any 
> memory issues in my tests). Feel free, to have a look and send me 
> feedback if you like. There are a number of things, that needs some 
> adjustment. But I think, I am through for the most important things :)

Very good.

I tried to build, and it worked out just fine with only one compiler
warning using gcc 6:

/home/pere/src/debian/xiph/oggvideotools-upstream-git/src/binaries/oggSlideshow.cpp: In function 'int oggSlideshowCmd(int, char**)':
/home/pere/src/debian/xiph/oggvideotools-upstream-git/src/binaries/oggSlideshow.cpp:285:8: warning: 'template<class> class std::auto_ptr' is deprecated [-Wdeprecated-declarations]
   std::auto_ptr<Effector> effector;
        ^~~~~~~~
In file included from /usr/include/c++/6/memory:81:0,
                 from /home/pere/src/debian/xiph/oggvideotools-upstream-git/src/binaries/oggSlideshow.cpp:39:
/usr/include/c++/6/bits/unique_ptr.h:49:28: note: declared here
   template<typename> class auto_ptr;
                            ^~~~~~~~

Btw, would it be possible to make sure the build test itself when doing
'make check' without requiring an Internet connection?  This would allow
the Debian package builders to run the test during building.  In the
debian package I ran code like this to first generate a video from a
picture and then operate on the video:

  echo "info: Generating Ogg Theora file"
  oggSlideshow /usr/share/pixmaps/debian-logo.png

  echo "info: Copy Ogg Theora file using oggJoin."
  oggJoin out.ogv slideshow.ogv

Perhaps you can generate a video using a similar technique instead of
downloading it?

-- 
Vennlig hilsen
Petter Reinholdtsen



More information about the pkg-xiph-maint mailing list