Bug#838866: vorbis-tools FTCBFS: does not honour DEB_BUILD_OPTIONS=nocheck

[Helmut Grohne]

Source: vorbis-tools
Version: 1.4.0-10
Tags: patch
User: helmutg at debian.org
Usertags: rebootstrap

vorbis-tools fails to cross build from source, because it runs tests
even when invoked with DEB_BUILD_OPTIONS=nocheck. Tests naturally fail,
because host architecture executables cannot be executed at all in a
cross build setting. The attached patch implements the necessary
handling of DEB_BUILD_OPTIONS=nocheck. Please consider applying it.

After applying it, vorbis-tools does not become cross buildable. It also
fails to find ao.pc using pkg-config, because ao.pc does not live in a
multiarch path. So #638741 needs to be fixed as well for actually cross
building vorbis-tools.

Helmut
-------------- next part --------------
diff --minimal -Nru vorbis-tools-1.4.0/debian/changelog vorbis-tools-1.4.0/debian/changelog
--- vorbis-tools-1.4.0/debian/changelog	2016-05-26 10:23:59.000000000 +0200
+++ vorbis-tools-1.4.0/debian/changelog	2016-09-25 23:05:14.000000000 +0200
@@ -1,3 +1,10 @@
+vorbis-tools (1.4.0-10.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Do not run tests under DEB_BUILD_OPTIONS=nocheck. (Closes: #-1)
+
+ -- Helmut Grohne <helmut at subdivi.de>  Sun, 25 Sep 2016 23:04:52 +0200
+
 vorbis-tools (1.4.0-10) unstable; urgency=medium
 
   * Drop debconf from autopkgtest dependencies.  We do not anything
diff --minimal -Nru vorbis-tools-1.4.0/debian/rules vorbis-tools-1.4.0/debian/rules
--- vorbis-tools-1.4.0/debian/rules	2016-05-26 09:33:16.000000000 +0200
+++ vorbis-tools-1.4.0/debian/rules	2016-09-25 23:04:50.000000000 +0200
@@ -28,8 +28,10 @@
 #CFLAGS += -D_FILE_OFFSET_BITS=64
 
 # Run our test suite until the upstream source get one
+ifeq ($(filter nocheck,$(DEB_BUILD_OPTIONS)),)
 override_dh_auto_test:
 	dh_auto_test
 	for t in debian/tests/test-*; do \
 	    BUILDDIR=`pwd` $$t; \
 	done
+endif