[Pkg-zfsonlinux-devel] Patches to build udeb's and module packages directly from source

[Carlos Alberto Lopez Perez]

On 07/05/13 19:25, Turbo Fredriksson wrote:
> The following changes since commit 5af840bfb19ddcbfd597c521d4c33c12d6e708ea:
> 
>   Forget about .pc files (2013-05-01 17:01:25 +0200)
> 
> are available in the git repository at:
>   git://github.com:FransUrbo/debian-spl.git ..BRANCH.NOT.VERIFIED..
> 
> Turbo Fredriksson (1):
>       * Build udebs and optionally modules package(s) - both .deb and .udeb.
> 
>  debian/changelog                                   |    7 +++
>  debian/{control => control.in}                     |    0
>  debian/control.modules.in                          |   46 ++++++++++++++++
>  debian/rules                                       |   55 ++++++++++++++++++++
>  debian/spl-modules-_KVERS_-udeb.dirs               |    2 +
>  debian/spl-modules-_KVERS_-udeb.install.modules.in |    2 +
>  6 files changed, 112 insertions(+), 0 deletions(-)
>  rename debian/{control => control.in} (100%)
>  create mode 100644 debian/control.modules.in
>  create mode 100644 debian/spl-modules-_KVERS_-udeb.dirs
>  create mode 100644 debian/spl-modules-_KVERS_-udeb.install.modules.in
> 
> 
> _______________________________________________
> Pkg-zfsonlinux-devel mailing list
> Pkg-zfsonlinux-devel at lists.alioth.debian.org
> https://lists.alioth.debian.org/mailman/listinfo/pkg-zfsonlinux-devel
> 

Thanks for the patches.

I only looked closely to this one for the moment. I have some comments

About the targets added to debian/rules

override_dh_configure_modules
override_dh_binary-modules-udeb
override_dh_binary-modules

How this rules are supposed to be executed by dh? At least in my system
they seem to override nothing.

Maybe calling override_dh_binary-modules and
override_dh_binary-modules-udeb at some point (before dh_auto_install?)
is missed?

If this is the case, then I think that naming the targets override_dh_*
is misleading, because they are not overriding any of the dh automatic
targets.

I tried to build the package both with git-buildpackage+cowbuilder and
dpkg-buildpackage and it didn't produced the udeb, nor any different deb
than the previous ones.

Perhaps you also missed to add module-assistant and
linux-headers-${arch} to the build-depends ? To catch this things is
helpful if you build the package in a clean environment with cowbuilder,
pbuilder, qemubuilder or something like that.

How you managed to build the udeb and the module package? What I am missing?


Regards!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-zfsonlinux-devel/attachments/20130509/7893ccc3/attachment.pgp>