[Pkg-zfsonlinux-devel] What can be done to make zfs-linux easier to review?

[Aron Xu]

On Fri, Feb 19, 2016 at 10:41 PM, Petter Reinholdtsen <pere at hungry.com> wrote:
>
> Until someone find time to look at my project membership application, I
> guess the best I can do is to send patches here.  Below is a simple fix
> addressing two issues with the copyright file.  In the process I
> investigated how to semi-automaticaly create and control the
> debian/control file and blogged about what I found out.  Please check
> out the tools mentioned in
> <URL: http://people.skolelinux.org/pere/blog/Creating__updating_and_checking_debian_copyright_semi_automatically.html >.
>
> I believe all issues identified by 'debmake -k' should be investigated,
> and suspect at least some of the many hundred issues identified by
> license-reconcile should be checked out.  But it is too verbose and a
> bit confused, so I suspect many false positives.
>
> Anyway, this patch fixes the remaining issues mentioned by the
> ftpmaster.  There are also other issues to fix, but I found it best to
> send this one first.
>
> From 8d0b5a83dded0876e76f37792b32a848e0cced2c Mon Sep 17 00:00:00 2001
> From: Petter Reinholdtsen <pere at hungry.com>
> Date: Fri, 19 Feb 2016 12:49:27 +0100
> Subject: [PATCH 1/2] debian/copyright: Document BSD license for
>  cmd/arc_summary/* and module/zfs/lz4.c.
>
> ---
>  debian/copyright | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/debian/copyright b/debian/copyright
> index df3be28..9c78c3f 100644
> --- a/debian/copyright
> +++ b/debian/copyright
> @@ -30,6 +30,13 @@ Files: *
>  Copyright: Lawrence Livermore National Security, LLC.
>  License: CDDL-1.0
>
> +Files: cmd/arc_summary/*
> +Copyright:
> +  2010, 2011, Jason J. Hellenthal <jhell at DataIX.net>
> +  2010, Martin Matuska <mm at FreeBSD.org>
> +  2008, Ben Rockwood <benr at cuddletech.com>
> +License: BSD-2-clause
> +
>  Files: cmd/mount_zfs/*
>  Copyright: Oracle
>   Lawrence Livermore National Security, LLC.
> @@ -980,6 +987,10 @@ Files: module/zfs/lzjb.c
>  Copyright: Oracle
>  License: CDDL-1.0
>
> +Files: module/zfs/lz4.c
> +Copyright: 2011-2013, Yann Collet
> +License: BSD-2-clause
> +
>  Files: module/zfs/metaslab.c
>  Copyright: Oracle
>   Delphix
> --
> 2.7.0
>

At least this patch looks good to me, please commit.

Regards,
Aron