[Pkg-zfsonlinux-devel] What can be done to make zfs-linux easier to review?

[Petter Reinholdtsen]

[Aron Xu]
> I believe years are not very big deal, the most important thing is
> specifying the license of every file...

I agree that correctly map files to licenses is the most important
thing, but see the advantage of knowing when the copyright expire too.
Anyway, if we use tools available to generate the copyright file, we can
get the year almost for free.

> Btw the membership was approved, you should be able to access the git
> repo.

Very good.  I've pushed the patch already.

The output from 'debmake -k' show these errors now:

Pattern #00: *
  File: contrib/bash_completion.d/zfs
        config/install-sh
- CDDL-1.0
+ MIT

Pattern #00: *
  File: config/ltoptions.m4
        config/lt~obsolete.m4
        config/ltversion.m4
        config/libtool.m4
        config/ltsugar.m4
- CDDL-1.0
+ PERMISSIVE

Pattern #19: config/config.guess
  File: config/config.guess
- GPL-2+
+ GPL-2.0+ with multiple exceptions XXX FIXME XXX

Pattern #20: config/config.sub
  File: config/config.sub
- GPL-2+
+ GPL-2.0+ with multiple exceptions XXX FIXME XXX

Pattern #21: config/depcomp
  File: config/depcomp
- GPL-2+
+ GPL-2.0+ with multiple exceptions XXX FIXME XXX

Pattern #22: config/ltmain.sh
  File: config/ltmain.sh
- GPL-2+
+ GPL-2.0+ with multiple exceptions XXX FIXME XXX

Pattern #23: config/missing
  File: config/missing
- GPL-2+
+ GPL-2.0+ with multiple exceptions XXX FIXME XXX

Pattern #24: debian/*
  File: debian/po/fr.po
        debian/po/ru.po
        debian/po/de.po
        debian/po/pl.po
        debian/po/da.po
        debian/po/cs.po
        debian/po/ja.po
        debian/po/zh_CN.po
        debian/po/templates.pot
        debian/po/pt.po
        debian/po/sv.po
- GPL-2+
+ CDDL-1.0

Pattern #25: debian/tree/zfsutils/usr/share/bash-completion/completions/zfs
  File: debian/tree/zfsutils/usr/share/bash-completion/completions/zfs
- Expat
+ MIT

Pattern #261: scripts/kmodtool
  File: scripts/kmodtool
- Expat
+ MIT


The Expat/MIT issue is a misclassification in debmake, while the others
seem to be real.  I'll push a fix for these soon, and after this I
believe the package is ready for a new upload.

I recommend having a look at the output from these commands to see if we
want to start over with a generated copyright file or not.

  licensecheck --copyright -r `find * -type f` | \
             /usr/lib/cdbs/licensecheck2dep5 > \
             debian/copyright.licensecheck.new && \
             mv debian/copyright.licensecheck.new debian/copyright.licensecheck

  cme update dpkg-copyright -quiet -file debian/copyright.cme
  
  debmake -cc > debian/copyright.debmake.new && \
             mv debian/copyright.debmake.new debian/copyright.debmake

The cme version look very good to me. :)

-- 
Happy hacking
Petter Reinholdtsen