Bug#456944: python-mechanize: forgot ``seek(0)'' in mechanize ``RobustFactory.set_response()''?

Arnaud Fontaine arnau at debian.org
Tue Dec 18 17:08:07 UTC 2007


A non-text attachment was scrubbed...
Name: clientform.diff
Type: text/x-diff
Size: 387 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-zope-developers/attachments/20071218/8cb9fa9b/attachment.diff 
-------------- next part --------------

Actually,  ``file.seek(0)'' has  been  added by  Titus in  ClientForm.py
because ``file'' position (parameter  of ``_ParseFileEx'' class) may not
be  at the  beginning. 

However, IMHO the ``seek''  shouldn't be performed in ClientForm because
the  file position  is only  modified  by ``RobustFactory.set_response''
(but not by DefaultFactory.set_response) when reading the response.

I have attached a patch that  fixes this problem for me and forwarded it
to twill at lists.idyll.org and wwwsearch-general at lists.sourceforge.net but
I didn't get an answer yet.

Regards,
Arnaud Fontaine

-------------- next part --------------
A non-text attachment was scrubbed...
Name: mechanize-seek.patch
Type: text/x-diff
Size: 480 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-zope-developers/attachments/20071218/8cb9fa9b/attachment.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-zope-developers/attachments/20071218/8cb9fa9b/attachment.pgp 


More information about the pkg-zope-developers mailing list