[RFR] templates://zope-common/{templates}

[Bernd Zeimetz]

As I've allready mentioned in a different mail, we're still working on
zop-ecommon and chances that templates are going to change are really
good. The new zope-common is in testing as it fixes some security
related issues (and a few others), but we're still not done with the
needed changes. But here're my comments on the suggested changes. All
parts I've removed from your mail are good imho.


>  Template: zope-common/remove-instance-without-data
>  Type: select
>  _Choices: abort, remove and continue
>  Default: abort
> -_Description: Found an old/incomplete zope instance '${instance}':
> - Found an old/incomplete ${instance} instance in
> - /var/lib/zope${zver}/instance/${instance}. No data file Data.fs was found
> - for the instance, meaning that the installation was not completed
> - for some reason, or the installation was incompletely removed.
> - Aborting the installation will allow you to inspect the state of the
> - instance, continuing will remove /var/lib/zope${zver}/instance/${instance}
> - and reinstall the ${instance}. Existing logfiles in
> +_Description: Action on old/incomplete zope instance '${instance}':
> 
> The short description was not a "prompt". It should really "introduce"
> the choice.
> 
> Rewriting it is tricky, though.
> 
> IMHO, turning this template into a boolean could be better, maybe.

I think this part will be changed anyway, as we need to check for far
more than only an existing or not existing Data.fs.


>  Template: zope-common/admin-user
>  Type: string
>  Default: admin
> -_Description: Admin user for zope instance '${instance}':
> - Please enter an admin user for the zope instance '${instance}'.
> - A valid user name starts with a letter, followed by letters and digits.
> - .
> - NOTE: Once the instance has been created, the parameter entered
> - here isn't relevant anymore.  To change the admin user (and password)
> - later on, call:
> +_Description: Administrative user for '${instance}' Zope instance:
> + Please enter the login name of the administrative user for the '${instance}' Zope instance .
> + A valid login name starts with a letter, followed by letters and digits.
> + .
> + This will only be used for the instance creation. To later change the
> + administrative user login name and password, please use the following
> + command:
>   .
>   /var/lib/zope${zver}/instance/${instance}/bin/zopectl adduser <user> <password>
> 
> s/admin/administrative: no abbreviation..:-)
> 
> We usually replace "user name" by "login name" which is more precise.
> 
> I think that "The <foo> Zope instance" is better English than "The
> Zope instance <foo>"
> 
> Use of "NOTE:", "WARNING:", "ATTENTION:" should be discouraged. All
> those texts are notes anyway.
> 
> I am unsure about "starts with a letter"...

a valid username has to start with a letter, not sure how to describe it
in a better way.



best regards,


Bernd

-- 
Bernd Zeimetz
<bernd at bzed.de>                         <http://bzed.de/>