[Po4a-devel]Re: [Po4a-commits] po4a/lib/Locale/Po4a TransTractor.pm,1.41,1.42

[Jordi Vilalta]

On Tue, 17 Aug 2004, Martin Quinson wrote:

> On Tue, Aug 17, 2004 at 10:38:53PM +0000, Jordi Vilalta wrote:
>> Update of /cvsroot/po4a/po4a/lib/Locale/Po4a
>> In directory haydn:/tmp/cvs-serv13365/lib/Locale/Po4a
>>
>> Modified Files:
>> 	TransTractor.pm
>> Log Message:
>> Say the reference to the first line with non-ascii encoding on error if it
>> couldn't determine the document encoding
>
> Thanks. Is is safe to make the same change at line 954, where this error
> message also appear?

While watching if it was safe I have noticed a wrong negation in the above 
conditions. Now it's fixed, and it is safe to put the same error message 
there (done).

> I reworded a bit the message. I prefer to say "at $ref" than "in $ref". I'm
> not sure which one is the best, but anyway.
>
> Moreover, I think we may want to go for a gcc-like notation when possible. Ie:
> FILE:LINE: error message.

Sounds good.

> Actually, the user probably don't really care whether the error comes from
> the core of po4a, or this or that module. Not speaking that he knows which
> module it is, most of the time, since he provided the -f flag...
>
> Another good point about that is that emacs undertand this notation and jump
> to the error point. I'm often pissed of by perl, which hides the error point
> right in the middle of the phrase, and I know realize I did the same for
> po4a :-/
>
> If you agree with me, I'm not sure whether we want to change this right away
> (and fuzzy 95% of the strings again), or later.

No problem for me. Most module names are already out of the error 
messages, and we should only remove the references in the middle of some 
messages (and it's relatively fast to update fuzzy messages).

Regards,

Jordi Vilalta