[Po4a-devel]Sgml.pm: Issue an error if nsgmls is missing
Martin Quinson
martin.quinson@loria.fr
Sat, 28 May 2005 21:04:46 +0200
--tsOsTdHNUZQcU9Ye
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sat, May 28, 2005 at 08:45:13PM +0200, Francois Gouget wrote:
>=20
> Here's a better version of this patch. The perl documentation says that=
=20
> when using
> open "cmd|" we can get the process exit code in '$?' after the close. So
> this is what this patch does. If everything went well nsgmls returns 0
> and this is what we should get. If anything went wrong we will get a
> non-zero error code and print a message.
>=20
> I also removed the 'cat' to not have multiple child processes though I=20
> don't think this is strictly necessary. But it seems cleaner and should=
=20
> be ever so slightly more efficient too.
>=20
>=20
> Changelog:
>=20
> * lib/Locale/Po4a/Sgml.pm
>=20
> Francois Gouget <fgouget@codeweavers.com>
> Check the nsgmls exit code and issue an error if it is non-zero.
> This lets us detect the case where nsgmls is missing.
Perfect, commited, thanks. I just changed the output to use the usual way to
do so (translating and wrapping).
Thanks again,
Mt.
--tsOsTdHNUZQcU9Ye
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
iD8DBQFCmMDOIiC/MeFF8zQRAmw0AJ96vKMKn0vIs4TCuAclz53sWZsUnACfSblH
+THlUp4HZAd/5sB6oJkPwHU=
=EGp4
-----END PGP SIGNATURE-----
--tsOsTdHNUZQcU9Ye--