[Po4a-devel] [po4a-Bugs][314748] Text.pm: add an option to force no wrap lines in translated text

[po4a-bugs at alioth.debian.org]

po4a-Bugs item #314748 was changed at 27/03/2017 18:02 by Martin Quinson
You can respond by visiting: 
https://alioth.debian.org/tracker/?func=detail&atid=410622&aid=314748&group_id=30267

>Status: Closed
Priority: 3
Submitted By: Alexander Golubev (fat-zer-guest)
Assigned to: Nobody (None)
Summary: Text.pm: add an option to force no wrap lines in translated text 
Category: None
Group: None
>Resolution: Fixed


Initial Comment:
subj;

such option may be useful when e.g. translating a docbook witch includes shell scripts directly to it self and the translator wants to get the same structure on output.


----------------------------------------------------------------------

>Comment By: Martin Quinson (mquinson)
Date: 27/03/2017 18:02

Message:
Hello,

I commited your patch, thus closing. Many thanks for that. Next time, I'll try to be a bit more reactive...

Bye, Mt.

----------------------------------------------------------------------

Comment By: Alexander Golubev (fat-zer-guest)
Date: 12/07/2014 03:14

Message:
Here is the promised patch.

I haven't done any unittest's yet because the Text module has no such yet.

----------------------------------------------------------------------

Comment By: Alexander Golubev (fat-zer-guest)
Date: 11/07/2014 18:46

Message:
> Also, I have a doubt about the fact that --auto accepts a comma separated list of tags that should be wrapped. It seems to me that your patch accepts a boolean option where wrap is completely disabled or not, am I wrong? If so, tests cases would be welcome. If I'm right please update the doc.

The patch accept 1 option --wrap with one of 3 parameters:
auto     : wrap lines, the current behavior
force_no : no line wrapping: the lines in the translation will be broken on the same place as they were in the source.
no       : even I don't clearly understand that's that option does =) it supposed to broke lines in special formats: asciidoc, control, debianchangelog, etc only if there are some special conditions. Although, I'm not really into those formats so I don't really know how that supposed to be done...

So IMO it would be better to stay only with 1 boolean option "--no-wrap" or "--force-no-wrap" to behave like the "--wrap=forse_no" in the current patch.

I'll prepare the new patch in a day...

----------------------------------------------------------------------

Comment By: Martin Quinson (mquinson)
Date: 09/07/2014 02:44

Message:
I would feel better if you could provide a little test case in the t/ directory to ensure that it works as expected (and that it still does in the future).

Also, I have a doubt about the fact that --auto accepts a comma separated list of tags that should be wrapped. It seems to me that your patch accepts a boolean option where wrap is completely disabled or not, am I wrong? If so, tests cases would be welcome. If I'm right please update the doc.

In any case, many thanks for the report and for the patch!

----------------------------------------------------------------------

Comment By: Alexander Golubev (fat-zer-guest)
Date: 07/07/2014 16:20

Message:
Here is a proposed patch... But somebody should review it...

----------------------------------------------------------------------

You can respond by visiting: 
https://alioth.debian.org/tracker/?func=detail&atid=410622&aid=314748&group_id=30267