[Pommed-devel] Support for Thinkpads

[Julien BLACHE]

Martin Aumueller <aumuell at reserv.at> wrote:

Hi,

> when using a Macbook Pro I learned to like pommed. So I missed its 
> functionality when switching to a Thinkpad. Here is a patch for handling LCD 
> brightness and volume (probably eject, too) on a T61p (and probably other 
> Thinkpad models, too). I really hope that it is acceptable for you to support 

Unfortunately, no, I do not wish to start adding support for non-Apple
machines. A generic hotkey event handler is just not my goal and it's
too much trouble; there's too much crap hardware in the wild.

There's a lot of code that would need to be either modularized or
generalized to properly add support for non-Apple machines; the sysfs
backlight driver is one (a painful one).

That being said, I have nothing against someone using pommed as a
base, but pommed really was designed for Apple machines (and it shows
:). Whatever is needed for a new machine, I know I can do it in pommed
in a couple of days at most; if pommed was to support any and all
machines, it'd take more time and care (and I love being able to add
support for the new machines between the time they're announced and
the time they ship, even if I can't do it every time).

> non-Apple hardware! This patch also includes an additional usb id for my 
> extern alu Apple keyboard.

Hmm, what kind of keymap do you have on this keyboard? There are
usually 3 variants (speaking of USB IDs) for the Apple keyboards, but
I don't know if this applies to the external keyboards too. Would be
interesting to compare to the IDs of your laptop's keyboard if you
have the same keymap on both.

> Attached is another patch which makes the OSD react a bit faster to audio 
> changes.

Hmm, you can move the call before the beep() call, but not further
up. Better change the volume then send out the notification (and
there's no error handling in this code, but I think I wanted some and
put that on the back burner - who cares, after all.)

JB.

-- 
Julien BLACHE                                   <http://www.jblache.org> 
<jb at jblache.org>                                  GPG KeyID 0xF5D65169