[Popcon-developers] Update to postinst
Petter Reinholdtsen
pere@hungry.com
Tue, 13 Apr 2004 19:00:20 +0200
[Bill Allombert]
> Hello Petter,
>
> I plan to update the postinst because:
>
> 1) Apparently the fix for EMPTYID is not working dur e to a typo
> in the sed regexp:
> - s/^MY_HOSTID="\\?$EMPTYID"\\?/MY_HOSTID=\"$MY_HOSTID\"/; \
> + s/^MY_HOSTID=\"\\?$EMPTYID\"\\?/MY_HOSTID=\"$MY_HOSTID\"/; \
Strange. It worked when I tested it. Did sed change behavoiur?
Anyway, I assume I was just messing up while testing. :/
> 2) The error condition cannot happen and the error message is not
> informational: it does not tell the users what is the problem and
> how they can fix it manually.
I would rather improve the error checking and improve the message,
unless we can get the package to a point where it will never fail.
> 3) The error check caused 2 lintian warnings.
Well, the db_input in postinst is harmless. We could move the test to
the config file, but I am not sure if it is useful.
>
> 4) I have implemented a fix for MY_HOSTID that end by ' -'.
Good.