Bug#231958: [Popcon-developers] Bug#231958: popularity-contest: XSIism in cronjob

Bill Allombert Bill Allombert <allomber@math.u-bordeaux.fr>, 231958@bugs.debian.org
Mon, 9 Feb 2004 23:50:33 +0100


On Mon, Feb 09, 2004 at 04:36:15PM -0500, Clint Adams wrote:
> Package: popularity-contest
> Version: 1.11
> Severity: serious
> Tags: patch
> 
> This is a #!/bin/sh script.
> 
> --- popularity-contest.orig	2004-02-09 16:33:25.689130693 -0500
> +++ popularity-contest	2004-02-09 16:34:37.406684668 -0500
> @@ -18,7 +18,7 @@
>  if [ -z "$MAILTO" ]; then exit 0; fi
>  
>  # don't run if PARTICIPATE is "no" or unset!
> -[ "$PARTICIPATE" = "no" -o -z "$PARTICIPATE" ] && exit 0
> +[ "$PARTICIPATE" = "no" ] || [ -z "$PARTICIPATE" ] && exit 0

The program [ in Debian supports -o. Do you mean a POSIX shell can
include a built-in '[' command that does not support this option ?
Can it include a built-in 'test' command ?

Cheers,
-- 
Bill. <ballombe@debian.org>

Imagine a large red swirl here.