[Popcon-developers] HTTP POST support and popcon

Petter Reinholdtsen pere@hungry.com
Sun, 03 Jul 2005 09:34:20 +0200


[Petter Reinholdtsen]
> The code looks fairly good to me.  A few comments:

I've commited the code to CVS now, disabled by default.

>  - Is there an existing perl module we could use for the HTTP
>    communication?  I'm not sure we want an extra dependency, but we
>    should consider it if we didn't have to add a dependency to get
>    access to a library handling this.

I didn't investigate this one yet.

>  - There is no timeout.  I tried to run the script now, it got stuck.
>    I believe it is because of network problems getting to
>    popcon.debian.org.  The script should try for some seconds, and
>    then give up.  I suggest using a simple timer.

This need to be added too.

>  - The content type used do not mention the compression used, nor that
>    this is in fact a plan text file.

I updated it to report x-gzip encoding and text/plain content type.

>  - The file name and popcon host should be fetched from the
>    configuration files used to specify this, or perhaps we should
>    specify it as a command line argument?

I implemented this too.

I'll try to find time to go through the bug list and see if there are
more bugs to close before uploading.  I also plan to add a low
priority debconf question to enable the http reporting, to make it
easier for users to enable it.

Bill, did you receive the test reports I submitted yesterday using
http?