[Reportbug-commits] [SCM] Reportbug - reports bugs in the Debian distribution branch, master, updated. 4.9-92-gdd39129

[Sandro Tosi]

The following commit has been merged in the master branch:
commit 7f0306bd3f0f514f51f302067e3d44fa7cb1e2ef
Author: Sandro Tosi <morph at debian.org>
Date:   Tue Apr 6 11:11:21 2010 +0200

    treat every FTBFS bug (pseudo-severity 'does-not-build') as 'serious' but adding a note in the Justification pseudo-header if the package was built successfully in the past; thanks to Alexander Schmehl for the report; Closes: #390466

diff --git a/bin/reportbug b/bin/reportbug
index 98e0a41..79e28b3 100755
--- a/bin/reportbug
+++ b/bin/reportbug
@@ -1863,30 +1863,23 @@ For more details, please see: http://www.debian.org/devel/wnpp/''')
                                                 http_proxy=self.options.http_proxy,
                                                 timeout=options.timeout)
 
+                severity = 'serious'
+                justification = 'fails to build from source'
+                # special-case only if it was built in the past
                 if built:
-                    ewrite('Successful past builds... treating as serious.\n')
-                    severity = 'serious'
-                    justification = 'no longer builds from source'
-                else:
-                    ewrite('No successful builds... treating as important.\n')
-                    severity = 'important'
-                    justification = 'fails to build from source'
+                    justification += ' (but built successfully in the past)'
             else:
-                if notatty:
-                    severity = 'important'
-                    justification = 'fails to build from source'
-                else:
+                severity = 'serious'
+                justification = 'fails to build from source'
+                if not notatty:
+                    # special-case only if it was built in the past
                     if ui.yes_no(
                         'Has this package successfully been built for this '
                         'architecture in the past (you can look this up at '
                         'buildd.debian.org)',
                         'Yes, this is a recently-introduced problem.',
                         'No, it has always been this way.'):
-                        severity = 'serious'
-                        justification = 'no longer builds from source'
-                    else:
-                        severity = 'important'
-                        justification = 'fails to build from source'
+                        justification += ' (but built successfully in the past)'
 
         HOMEDIR = os.environ.get('HOME', '/')
 
diff --git a/debian/changelog b/debian/changelog
index 3ace924..dcb3450 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -12,6 +12,10 @@ reportbug (4.12) UNRELEASED; urgency=low
     - keep presenting the severity menu until one is selected (prevent a crash
       with urwid UI and Cancel button); thanks to Noah Slater for the report;
       Closes: #461908
+    - treat every FTBFS bug (pseudo-severity 'does-not-build') as 'serious' but
+      adding a note in the Justification pseudo-header if the package was built
+      successfully in the past; thanks to Alexander Schmehl for the report;
+      Closes: #390466
   * reportbug/submit.py
     - clarify that in case no acknowledge is received, then there was an error;
       thanks to mpapet for the report; Closes: #575418
@@ -51,7 +55,7 @@ reportbug (4.12) UNRELEASED; urgency=low
       script to remove that notice); thanks to Chris Walker for the report;
       Closes: #488414
 
- -- Sandro Tosi <morph at debian.org>  Mon, 05 Apr 2010 15:43:26 +0200
+ -- Sandro Tosi <morph at debian.org>  Tue, 06 Apr 2010 11:09:14 +0200
 
 reportbug (4.11) unstable; urgency=low
 

-- 
Reportbug - reports bugs in the Debian distribution