[Reportbug-commits] [reportbug] 01/01: changed to "No" the default to local MTA question in configuration mode; thanks to Hartmut Bruening for the report; Closes: #732789

[Sandro Tosi]

This is an automated email from the git hooks/post-receive script.

morph pushed a commit to branch master
in repository reportbug.

commit db2bd8b4fdf9054c2b19426c0c84902862581d7c
Author: Sandro Tosi <morph at debian.org>
Date:   Thu Jan 2 19:59:07 2014 +0100

    changed to "No" the default to local MTA question in configuration mode; thanks to Hartmut Bruening for the report; Closes: #732789
    
    Since in the initial configuration smptout is None, then just writing
    
        False or (not options.smtpout)
    
    will result in a True value (hence a Y default) since "not None == True".
---
 bin/reportbug    | 3 +--
 debian/changelog | 8 ++++++++
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/bin/reportbug b/bin/reportbug
index 774eaad..31468cf 100755
--- a/bin/reportbug
+++ b/bin/reportbug
@@ -587,7 +587,6 @@ def offer_configuration(options):
         is_addr_ok = utils.check_email_addr(from_addr)
         if not is_addr_ok:
             ewrite('Your email address is not valid; please try another one.\n')
-
     stupidmode = not ui.yes_no(
         'Do you have a "mail transport agent" (MTA) like Exim, Postfix or '
         'SSMTP configured on this computer to send mail to the Internet?',
@@ -595,7 +594,7 @@ def offer_configuration(options):
         'If you can send email from this machine without setting an SMTP Host '
         'in your mailer, you should choose this answer.',
         'No, I need to use an SMTP Host or I don\'t know if I have an MTA.',
-        (not options.smtphost))
+        (not options.smtphost) if options.smtphost else False)
 
     if stupidmode:
         opts = []
diff --git a/debian/changelog b/debian/changelog
index 9fc9fd8..b3cd320 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+reportbug (6.4.5) UNRELEASED; urgency=low
+
+  * bin/reportbug
+    - changed to "No" the default to local MTA question in configuration mode;
+      thanks to Hartmut Bruening for the report; Closes: #732789
+
+ -- Sandro Tosi <morph at debian.org>  Thu, 02 Jan 2014 19:56:52 +0100
+
 reportbug (6.4.4) unstable; urgency=low
 
   * reportbug/ui/gtk2_ui.py

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reportbug/reportbug.git