[Reportbug-maint] Reportbug - adding a GTK UI

Luca Bruno lethalman88 at gmail.com
Sat Sep 6 09:23:29 UTC 2008

Hash: SHA1

On Sat, 6 Sep 2008 00:39:41 +0200
"Sandro Tosi" <matrixhasu at gmail.com> wrote:

> Hi Luca,
> On Thu, Sep 4, 2008 at 19:38, Sandro Tosi <matrixhasu at gmail.com> wrote:
> > all applied as of r645.
> some notes:
> * I don't like too much the replace of sys.excephook in gtk2_ui.py:
> due to all UIs being imported in ui/__init__.py, all the exception
> will be handled by the gtk error handler (even if another ui will be
> choosen). 

The excepthook will call the oldhook too.

> Can you use a different method to handle exceptions in GTK+
> UI? Alternatively overwrite it only if we're really using GTK+ UI (I
> can "workaround" it in __init__, restoring the default error handler
> if we're not using gtk+, but I don't like it either :) ).

This is the problem of using modules as classes ;)

> * window size: I'd choose a window size bigger than the "initial" one,
> and at least so that it won't change during window navigation.

I do agree. In the patch I have set 800x600 the bugs dialog, but I haven't tried it due to packages.debian.org downtime.

> * set the focus on the input fields: for example when promping for
> subject and report text the prompt should be already on the input
> field so one can just start writing.

Ok this needs a little hack in the Page class, nothing bad.

> Thanks,
> Sandro

Patches attached, they might need the previous 3 patches to be committed.
Shouldn't be a pain if you don't want to commit the previous 3.

- -- 
http://syx.googlecode.com - Smalltalk YX
http://lethalman.blogspot.com - Thoughts about computer technologies
http://www.ammazzatecitutti.org - Ammazzateci tutti
Version: GnuPG v1.4.9 (GNU/Linux)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-UI-initialization-with-initialize.patch
Type: text/x-patch
Size: 3718 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/reportbug-maint/attachments/20080906/25a5844d/attachment-0003.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Request-size-for-gtk-windows.patch
Type: text/x-patch
Size: 1073 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/reportbug-maint/attachments/20080906/25a5844d/attachment-0004.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Setup-focus-for-assistant-pages.patch
Type: text/x-patch
Size: 2651 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/reportbug-maint/attachments/20080906/25a5844d/attachment-0005.bin 

More information about the Reportbug-maint mailing list