[Reportbug-maint] Reportbug - adding a GTK UI
lethalman88 at gmail.com
Sat Sep 6 10:02:42 UTC 2008
-----BEGIN PGP SIGNED MESSAGE-----
On Sat, 6 Sep 2008 11:54:39 +0200
"Sandro Tosi" <matrixhasu at gmail.com> wrote:
> >> * window size: I'd choose a window size bigger than the "initial" one,
> >> and at least so that it won't change during window navigation.
> > I do agree. In the patch I have set 800x600 the bugs dialog, but I haven't tried it due to packages.debian.org downtime.
> use -O to skip internet tests
- -O won't show the BTS query
> > Patches attached, they might need the previous 3 patches to be committed.
> > Shouldn't be a pain if you don't want to commit the previous 3.
> both patches series applied (committed at r647), but:
> $ reportbug --ui gtk2 -O --debug checkgmail
> Traceback (most recent call last):
> File "/usr/bin/reportbug", line 1821, in <module>
> File "/usr/bin/reportbug", line 844, in main
> return iface.user_interface()
> File "/usr/bin/reportbug", line 1029, in user_interface
> "Please change your locale if this is incorrect.\n\n", charset)
> File "/usr/bin/reportbug", line 82, in ewrite
> return quietly or ui.log_message(*args)
> File "/usr/lib/python2.5/site-packages/reportbug/ui/gtk2_ui.py",
> line 1199, in log_message
> return assistant.set_progress_label (*args, **kwargs)
> NameError: global name 'assistant' is not defined
In the second patch a def initialize() has been introduced.
I haven't touched elsewhere in the code but this is what I happened to think:
1) All UIs should have initialize()
2) After the UI has been chosen from /usr/bin/reportbug, ui.initialize() must be called
How does it sounds to you? I think it's normal for applications to know when they start.
http://syx.googlecode.com - Smalltalk YX
http://lethalman.blogspot.com - Thoughts about computer technologies
http://www.ammazzatecitutti.org - Ammazzateci tutti
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
-----END PGP SIGNATURE-----
More information about the Reportbug-maint