[Reportbug-maint] Bug#537449: Don't stop on no subject

[Carl Chenet]

Package: reportbug
Version: 4.5
Severity: normal
Tags: patch

Hi,

Thanks for the bug report. Here is a patch to loop until the user provides a subject instead of just leaving.

Bye,
Carl Chenet


-- Package-specific info:
** Environment settings:
DEBEMAIL="chaica at ohmytux.com"
DEBFULLNAME="Carl Chenet"
INTERFACE="text"

** /home/chaica/.reportbugrc:
reportbug_version "4.5"
mode novice
ui text
smtphost "smtp.free.fr"

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.26-1-686 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages reportbug depends on:
ii  apt                           0.7.21     Advanced front-end for dpkg
ii  python                        2.5.4-2    An interactive high-level object-o
ii  python-reportbug              4.5        Python modules for interacting wit

reportbug recommends no packages.

Versions of packages reportbug suggests:
pn  debconf-utils                 <none>     (no description available)
ii  debsums                       2.0.44     verification of installed package 
pn  dlocate                       <none>     (no description available)
ii  exim4                         4.69-9     metapackage to ease Exim MTA (v4) 
ii  exim4-daemon-light [mail-tran 4.69-9     lightweight Exim MTA (v4) daemon
ii  file                          5.00-1     Determines file type using "magic"
ii  gnupg                         1.4.9-4    GNU privacy guard - a free PGP rep
pn  python-gnome2-extras          <none>     (no description available)
pn  python-gtk2                   <none>     (no description available)
pn  python-urwid                  <none>     (no description available)
pn  python-vte                    <none>     (no description available)

-- no debconf information
-------------- next part --------------
>From 054bf939de943b03efd686e3f7b6cd46d7ad9608 Mon Sep 17 00:00:00 2001
From: chaica <chaica at ohmytux.com>
Date: Sun, 19 Jul 2009 23:26:15 +0200
Subject: [PATCH] do not stop on subject

---
 bin/reportbug |   22 +++++++++++++---------
 1 files changed, 13 insertions(+), 9 deletions(-)

diff --git a/bin/reportbug b/bin/reportbug
index ff48d77..5d13f61 100755
--- a/bin/reportbug
+++ b/bin/reportbug
@@ -1600,15 +1600,19 @@ For more details, please see: http://www.debian.org/devel/wnpp/''')
                     pkgversion = None
         elif not subject and not notatty:
             prompted = True
-            subject = ui.get_string(
-                'Please briefly describe your problem (max. 100 characters allowed; you can elaborate in '
-                'a moment; an empty response will stop reportbug).  This will '
-		'be the bug email subject, so write a concise summary of what '
-		'is wrong with the package, for example, "fails to send email" '
-		'or "does not start with -q option specified."', force_prompt=True)
-
-        if not subject:
-            efail("No subject specified; stopping.\n")
+            subject_ok = False
+            while not subject_ok:
+                subject = ui.get_string(
+                    'Please briefly describe your problem (max. 100 characters allowed; you can elaborate in '
+                    'a moment; an empty response will stop reportbug).  This will '
+            'be the bug email subject, so write a concise summary of what '
+            'is wrong with the package, for example, "fails to send email" '
+            'or "does not start with -q option specified."', force_prompt=True)
+
+                if not subject:
+                    ewrite("Providing a subject is mandatory.\n")
+                else:
+                    subject_ok = True
 
         if len(subject) > 100 and prompted and mode < MODE_EXPERT:
             subject = ui.get_string(
-- 
1.6.2.3