[Reportbug-maint] Bug#363920: Problem with mua

[chaica]

You're right, I haven't been testing with both --mua and --<mua>, I'll
have a look.

Bye,
Carl

Le jeudi 14 mai 2009 à 17:51 +0200, Sandro Tosi a écrit :
> Hi Carl,
> 
> On Tue, May 12, 2009 at 23:32, chaica <chaica at ohmytux.com> wrote:
> > Hi Sandro,
> >
> > With the latests version in the git repo, it seems to have a problem
> > with the mua :
> >
> > chaica at sid:~$ reportbug --debug --mutt reportbug
> > Traceback (most recent call last):
> >  File "/usr/bin/reportbug", line 1869, in <module>
> >    main()
> >  File "/usr/bin/reportbug", line 862, in main
> >    if not utils.mua_exists(options.mua):
> >  File "/usr/lib/pymodules/python2.5/reportbug/utils.py", line 774, in
> > mua_exists
> >    returnvalue = subprocess.call(MUAVERSION[mua], stdout=open(output,
> > 'w'), stderr=subprocess.STDOUT, shell=True)
> > KeyError: 'mutt -H'
> >
> > It seems my patch was modified, allowing this keyError :
> 
> yes, I changed because I've tested with "--mua <mua>" infact:
> 
> $ git pull
> Already up-to-date.
> $ git status
> # On branch master
> nothing to commit (working directory clean)
> $ PYTHONPATH=. ./bin/reportbug --mua af -O --debug reportbug
> Selected mail user agent cannot be found; exiting.
> $ PYTHONPATH=. ./bin/reportbug --af -O --debug reportbug
> Traceback (most recent call last):
>   File "./bin/reportbug", line 1869, in <module>
>     main()
>   File "./bin/reportbug", line 862, in main
>     if not utils.mua_exists(options.mua):
>   File "/home/morph/deb/reportbug/reportbug/utils.py", line 774, in mua_exists
>     returnvalue = subprocess.call(MUAVERSION[mua], stdout=open(output,
> 'w'), stderr=subprocess.STDOUT, shell=True)
> KeyError: 'af -EH < '
> 
> I don't think we should allow for MUA[<mua>] keys to address values on
> MUAVERSION dict. Sadly I don't have that time to debug it, but I
> suppose that using --<mua> (instead of --mua <mua>) access teh MUA
> dict and returns the value instead of keep it as the key (to later
> address MUA dict).
> 
> Thanks a lot for the effort you put in fixing reportbug issues.
> 
> Cheers,