[Reportbug-maint] Bug#594354: reportbug: GTK ui crashes on presubj depending on file content

[Mike Miller]

Package: python-reportbug
Version: 4.12.6
Severity: normal
Tags: patch

Running "reportbug chromium-browser" consistently crashes reportbug at the
presubj stage with the following error:

Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.6/reportbug/ui/gtk2_ui.py", line 491, in
callback
    func (*args, **kwargs)
  File "/usr/lib/pymodules/python2.6/reportbug/ui/gtk2_ui.py", line 540, in
execute_operation
    self.execute (*args, **kwargs)
  File "/usr/lib/pymodules/python2.6/reportbug/ui/gtk2_ui.py", line 1081, in
execute
    self.view.get_buffer().set_text (message % args)
TypeError: not enough arguments for format string

In the GTK ui, the text of the presubj file is unconditionally processed with
the python format operator without any restrictions placed on the content of
the file.

The contents of /usr/share/bug/chromium-browser/presubj:
*** Please submit non packaging issue (e.g. feature requests) bugs to
the Debian BTS and the upstream bug tracking system
(http://code.google.com/p/chromium/issues/entry?template=Defect%20on%20Linux)
and put a reference to the upstream bug in the Debian bug report to ease bug
triage for the maintainers. Thank you. ***

If you get crashes, please read this wiki page to provide a proper
backtrace for your crash:
http://wiki.debian.org/Chromium/Debugging


The "%" characters in the URL string are interpreted as format codes when the
text should instead be displayed literally.  I have a fix that only applies the
format operator if arguments were passed similar to the behavior of other
functions in the ui libraries.  Another fix would be to remove the "args"
argument and accept only a single argument, which more accurately matches the
behavior of the text ui.



-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)

Kernel: Linux 2.6.32-5-686 (SMP w/2 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages python-reportbug depends on:
ii  apt                           0.7.25.3   Advanced front-end for dpkg
ii  python                        2.6.5-13   interactive high-level object-orie
ii  python-support                1.0.9      automated rebuilding support for P

python-reportbug recommends no packages.

Versions of packages python-reportbug suggests:
ii  reportbug                     4.12.6     reports bugs in the Debian distrib
-------------- next part --------------
A non-text attachment was scrubbed...
Name: reportbug-gtk2-presubj-format-parse-error.patch
Type: text/x-diff
Size: 502 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/reportbug-maint/attachments/20100825/f30ad8d0/attachment.patch>