[Reportbug-maint] Bug#810944: querybts: Mutt looks garbled after SIGWINCH

[Daniel Shahaf]

Package: reportbug
Version: 6.6.6
Severity: normal
Tags: patch

Dear Maintainer,

   * What led up to the situation?

I ran 'querybts' in an xterm and resized the xterm while querybts was running.

   * What exactly did you do (or not do) that was effective (or
     ineffective)?

1. Resize the terminal to 80x25.
2. Run 'querybts 808808'.
3. Maximize the terminal window.  [This can be done during or after the
   next step, too, but must be done after typing <Enter> at the end of
   the previous step.]
4. Type <q><e><Enter> to close 'less' and open 'mutt'.

   * What was the outcome of this action?

Mutt only used the top-left 80x25 cells of the terminal.

   * What outcome did you expect instead?

Mutt using the full size of the maximized terminal.

   *

The root of the problem is that the $LINES and $COLUMNS environment variables
have outdated values after the resize.  Having a SIGWINCH handler that either
unsets those two variables or updates their values fixes the issue.  Patches
to do both are attached.

(The patches are mutually exclusive.)

Cheers,

Daniel

P.S. Full disclosure: The code in the putenv() patch is based on Apache
Licensed code from [1].  I assume that is okay.
[1] https://svn.apache.org/viewvc/subversion/trunk/build/run_tests.py?revision=1717356&view=markup#l81


-- Package-specific info:
** Environment settings:
DEBEMAIL="Daniel Shahaf <danielsh at apache.org>"
DEBFULLNAME="Daniel Shahaf"
INTERFACE="text"

** /home/daniel/.reportbugrc:
reportbug_version "6.6.3"
mode standard
ui text
realname "Daniel Shahaf"
email "danielsh at apache.org"
no-cc
header "X-Debbugs-CC: danielsh at apache.org"
smtphost reportbug.debian.org
mbox_reader_cmd "mutt -f %s"

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.3.0-1-amd64 (SMP w/1 CPU core)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages reportbug depends on:
ii  apt               1.1.10
ii  python-reportbug  6.6.6
pn  python:any        <none>

reportbug recommends no packages.

Versions of packages reportbug suggests:
pn  claws-mail                                 <none>
pn  debconf-utils                              <none>
pn  debsums                                    <none>
pn  dlocate                                    <none>
pn  emacs23-bin-common | emacs24-bin-common    <none>
ii  exim4                                      4.86-7
ii  exim4-daemon-light [mail-transport-agent]  4.86-7+b1
ii  file                                       1:5.25-2
ii  gnupg                                      1.4.20-1
pn  python-gtk2                                <none>
pn  python-gtkspellcheck                       <none>
pn  python-urwid                               <none>
pn  python-vte                                 <none>
pn  xdg-utils                                  <none>

Versions of packages python-reportbug depends on:
ii  apt               1.1.10
ii  file              1:5.25-2
ii  python-debian     0.1.27
ii  python-debianbts  2.6.0
pn  python:any        <none>

python-reportbug suggests no packages.

-- no debconf information
-------------- next part --------------
A non-text attachment was scrubbed...
Name: querybts-winch-putenv.diff
Type: text/x-diff
Size: 1343 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/reportbug-maint/attachments/20160114/e97f436e/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: querybts-winch-unsetenv.diff
Type: text/x-diff
Size: 1040 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/reportbug-maint/attachments/20160114/e97f436e/attachment-0001.diff>