[Reportbug-maint] Bug#850733: Bug#850733: Crashes with "TypeError: GObject.__init__() takes exactly 0 arguments (1 given)"

[Simon McVittie]

On Sat, 14 Jan 2017 at 23:36:55 +0000, James Clarke wrote:
> It seems GetMultilinePage's get_value also has a call to get_text without
> the extra parameter, but a grep for GetMultilinePage only shows the class
> definition, with no uses... deletion candidate? From what I can tell, it
> was added in 3739eb89aa, but even then it wasn't being used by anything?
> Anyway, if it needs to stay, the extra True needs to be added to it too.

There's also infinite recursion here, if the prompt doesn't contain ENTER:

def get_multiline(prompt, *args, **kwargs):
    _assert_context(reportbug_context)
    if 'ENTER' in prompt:
        # This is a list, let's handle it the best way
        return get_list(prompt, *args, **kwargs)
    else:
        return get_multiline(prompt, *args, **kwargs)

I suspect that last line was intended to be a GetMultilinePage wrapper.
But I can't actually test this, because the only use of get_multiline()
does have ENTER in its prompt (and it crashes - fix attached).

I also turned on deprecation warnings (python -Wall) and fixed most
of them. Some remain, particularly constructors for dialogs; I don't
know PyGTK well enough to immediately know what it wants there.

    S
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-gtk2_ui-hook-up-GetMultilinePage-the-way-it-was-pres.patch
Type: text/x-diff
Size: 1191 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/reportbug-maint/attachments/20170115/c76b3b65/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0011-gtk2_ui-Use-modern-form-of-constructor-for-Gtk.Align.patch
Type: text/x-diff
Size: 2980 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/reportbug-maint/attachments/20170115/c76b3b65/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0012-gtk2_ui-Reduce-deprecation-spam-by-using-named-prope.patch
Type: text/x-diff
Size: 4568 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/reportbug-maint/attachments/20170115/c76b3b65/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0013-gtk2_ui-Reduce-deprecation-spam-by-using-named-const.patch
Type: text/x-diff
Size: 2212 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/reportbug-maint/attachments/20170115/c76b3b65/attachment-0003.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0014-gtk2_ui-Remove-deprecated-threading-calls-that-no-lo.patch
Type: text/x-diff
Size: 948 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/reportbug-maint/attachments/20170115/c76b3b65/attachment-0004.patch>