[Reproducible-commits] [strip-nondeterminism] 01/04: Remove FIXME comment from ar handler

Andrew Ayer agwa at andrewayer.name
Sat Sep 27 16:21:35 UTC 2014


This is an automated email from the git hooks/post-receive script.

agwa-guest pushed a commit to branch debian
in repository strip-nondeterminism.

commit 9546dcd6f8cad6b8cecc827292b1db247394f2b9
Author: Andrew Ayer <agwa at andrewayer.name>
Date:   Sat Sep 27 08:49:03 2014 -0700

    Remove FIXME comment from ar handler
    
    After consulting with ntyni, the code works so the FIXME isn't warranted,
    though a comment has been left to indicate some uncertainty about its
    correctness.
---
 lib/File/StripNondeterminism/handlers/ar.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/File/StripNondeterminism/handlers/ar.pm b/lib/File/StripNondeterminism/handlers/ar.pm
index e8bec23..ca4a0a8 100644
--- a/lib/File/StripNondeterminism/handlers/ar.pm
+++ b/lib/File/StripNondeterminism/handlers/ar.pm
@@ -58,7 +58,7 @@ sub normalize {
 		#48     57     File size in bytes        Decimal
 		#58     59     File magic                \140\012
 
-		# FIXME: is this correct?
+		# not quite sure if this is correct but it seems to work
 		last if $count == 1 and eof($fh) and $buf eq "\n";
 
 		die "Incorrect header length"

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/strip-nondeterminism.git



More information about the Reproducible-commits mailing list