[Reproducible-commits] [presentations] 01/01: work in progress, color dif + asm code

[Holger Levsen]

This is an automated email from the git hooks/post-receive script.

holger pushed a commit to branch wip
in repository presentations.

commit e90540cf5dbf1713928b1eb2c028dd81b2703dd9
Author: Holger Levsen <holger at layer-acht.org>
Date:   Tue Jan 20 16:48:57 2015 +0100

    work in progress, color dif + asm code
---
 2015-01-31-FOSDEM15/2015-01-31-FOSDEM15.mdwn | 22 +++++++++++++++++++---
 1 file changed, 19 insertions(+), 3 deletions(-)

diff --git a/2015-01-31-FOSDEM15/2015-01-31-FOSDEM15.mdwn b/2015-01-31-FOSDEM15/2015-01-31-FOSDEM15.mdwn
index 976ac15..43d0b65 100644
--- a/2015-01-31-FOSDEM15/2015-01-31-FOSDEM15.mdwn
+++ b/2015-01-31-FOSDEM15/2015-01-31-FOSDEM15.mdwn
@@ -84,16 +84,32 @@ How small can a backdoor be?
 
 OpenSSH 3.0.2 (CVE-2002-0083) – exploitable security bug (privilege escalation: user can get root)
 
-~~~~
+~~~~diff
 {
   Channel *c;
 -     if (id < 0 || id > channels_alloc) {
 +     if (id < 0 || id >= channels_alloc) {
   log("channel_lookup: %d: bad id", id);
   return
-~~~~
+~~~~diff
+
+Result of fixing the bug (asm)
+------------------------------
+
+before			after
+------			-----
+cmpl	$0x0,0x8(%ebp)	cmpl $0x0,0x8(%ebp)
+js	16		js	16
+mov	0x4,%eax	mov 	0x4,%eax
+cmp	%eax,0x8(%ebp)	cmp 	%eax,0x8(%ebp)
+jle	30		jl	30
+mov	0x8(%ebp),%eax	mov	0x8(%ebp),%eax
+mov	%eax,0x4(%esp)	mov	%eax,0x4(%esp)
+movl	$0x4c,(%esp)	movl	$0x4c,(%esp)
+call	25		call	25
+
+
 
-FIXME: the - line should be red, and the + line should be green...
 
 Why
 ---

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/presentations.git