[Reproducible-commits] [dpkg] 06/61: libdpkg, dpkg-divert: Mark unimportant unlink() return code as unwanted

[Jérémy Bobbio]

This is an automated email from the git hooks/post-receive script.

lunar pushed a commit to branch pu/reproducible_builds
in repository dpkg.

commit 7d493c3ce4c816ba2142f29066f26f6bc4b63b54
Author: Guillem Jover <guillem at debian.org>
Date:   Wed Apr 30 22:04:43 2014 +0200

    libdpkg, dpkg-divert: Mark unimportant unlink() return code as unwanted
    
    Make it explicit that we do not care about the return code of these
    unlink() calls.
    
    Warned-by: coverity
---
 lib/dpkg/cleanup.c  | 2 +-
 lib/dpkg/dbmodify.c | 2 +-
 src/divertcmd.c     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/dpkg/cleanup.c b/lib/dpkg/cleanup.c
index 5680f0e..8cce9e0 100644
--- a/lib/dpkg/cleanup.c
+++ b/lib/dpkg/cleanup.c
@@ -65,5 +65,5 @@ cu_filename(int argc, void **argv)
 {
 	const char *filename = argv[0];
 
-	unlink(filename);
+	(void)unlink(filename);
 }
diff --git a/lib/dpkg/dbmodify.c b/lib/dpkg/dbmodify.c
index 14f8bae..b6a2350 100644
--- a/lib/dpkg/dbmodify.c
+++ b/lib/dpkg/dbmodify.c
@@ -332,7 +332,7 @@ void modstatdb_shutdown(void) {
     modstatdb_checkpoint();
     /* Tidy up a bit, but don't worry too much about failure. */
     fclose(importanttmp);
-    unlink(importanttmpfile);
+    (void)unlink(importanttmpfile);
     varbuf_destroy(&uvb);
     /* Fall through. */
   case msdbrw_needsuperuserlockonly:
diff --git a/src/divertcmd.c b/src/divertcmd.c
index 05ea5c5..dc035c2 100644
--- a/src/divertcmd.c
+++ b/src/divertcmd.c
@@ -165,7 +165,7 @@ check_writable_dir(struct file *f)
 	if (tmpfd < 0)
 		ohshite(_("error checking '%s'"), f->name);
 	close(tmpfd);
-	unlink(tmpname);
+	(void)unlink(tmpname);
 
 	free(tmpname);
 }

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/dpkg.git