[Reproducible-commits] [diffoscope] 01/01: Use portable arguments for cmp

Jérémy Bobbio lunar at moszumanska.debian.org
Wed Dec 2 14:19:11 UTC 2015


This is an automated email from the git hooks/post-receive script.

lunar pushed a commit to branch master
in repository diffoscope.

commit 3d17ccc297dd7ff0974a52bf8efcb4c9ea75ce7f
Author: Baptiste Daroussin <bapt at gandi.net>
Date:   Wed Dec 2 13:55:29 2015 +0100

    Use portable arguments for cmp
    
    `--silent` is a GNUism and we want diffoscope to work on FreeBSD and other
    systems.
---
 diffoscope/comparators/binary.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/diffoscope/comparators/binary.py b/diffoscope/comparators/binary.py
index cc2d5d9..33d27fe 100644
--- a/diffoscope/comparators/binary.py
+++ b/diffoscope/comparators/binary.py
@@ -185,7 +185,7 @@ class File(object, metaclass=ABCMeta):
             if open(self.path, 'rb').read() == open(other.path, 'rb').read():
                 return True
 
-        return 0 == subprocess.call(['cmp', '--silent', self.path, other.path],
+        return 0 == subprocess.call(['cmp', '-s', self.path, other.path],
                                     shell=False, close_fds=True)
 
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/diffoscope.git



More information about the Reproducible-commits mailing list