[Reproducible-commits] [dpkg] 62/105: build: Quote dirname argument

Niko Tyni ntyni at moszumanska.debian.org
Mon May 2 13:49:53 UTC 2016


This is an automated email from the git hooks/post-receive script.

ntyni pushed a commit to branch ntyni/reproducible_builds
in repository dpkg.

commit 11912fc691d60acaa84d50ea5e325248a97b0ba3
Author: Guillem Jover <guillem at debian.org>
Date:   Tue Apr 19 17:23:09 2016 +0200

    build: Quote dirname argument
    
    We should protect this argument in case the user has the source tree
    in a pathname with spaces.
    
    Reported-by: Carsten Hey <carsten at debian.org>
---
 debian/changelog | 2 ++
 run-script       | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/debian/changelog b/debian/changelog
index a28ba10..f2bab71 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -92,6 +92,8 @@ dpkg (1.18.5) UNRELEASED; urgency=medium
     - Add a configuration summary to configure output.
     - Make git log invocation immune to local configuration.
     - Do not require passing the perl interpreter to run-script.
+    - Quote dirname argument in run-script, to handle spaces in pathname.
+      Reported by Carsten Hey <carsten at debian.org>.
   * Packaging:
     - Enable all hardening flags, starting with gcc-5 there is no performance
       loss anymore when enabling PIE on i386.
diff --git a/run-script b/run-script
index 3e20e39..b3ab8dd 100755
--- a/run-script
+++ b/run-script
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-top_srcdir="`dirname $0`"
+top_srcdir="`dirname "$0"`"
 
 # To avoid using «readlink -f» or «realpath» we just change into the
 # desired directory and work from there.

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/dpkg.git



More information about the Reproducible-commits mailing list