[Reproducible-commits] [dpkg] 05/24: dpkg: Fix file queue tail assignment in file queue pop

[Niko Tyni]

This is an automated email from the git hooks/post-receive script.

ntyni pushed a commit to branch ntyni/reproducible_builds
in repository dpkg.

commit c931762286a22626b4f9958d457248a027bfc0f7
Author: Guillem Jover <guillem at debian.org>
Date:   Tue May 3 18:11:06 2016 +0200

    dpkg: Fix file queue tail assignment in file queue pop
    
    When we are popping a file from the files queue, we might end up messing
    it up. To check for the side-effects on the file-system one should look
    for files with .dpkg-new extension for packages that have been fully
    configured and where those files are not listed as owned by them. These
    packages will need to be reinstalled.
    
    Closes: #823288
---
 debian/changelog | 4 ++++
 src/archives.c   | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/debian/changelog b/debian/changelog
index b8acd2b..e070e58 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,5 +1,9 @@
 dpkg (1.18.6) UNRELEASED; urgency=medium
 
+  * Fix file queue tail assignment on file queue pop during unpack. This
+    could mess up the file queue in some circumstances and leave behind
+    files in the filesystem as «pathname».dpkg-new after configuration
+    and without traces of the files in the dpkg database. Closes: #823288
   * Packaging:
     - Bump Standards-Version to 3.9.8 (no changes needed).
 
diff --git a/src/archives.c b/src/archives.c
index ae7fa30..f66e818 100644
--- a/src/archives.c
+++ b/src/archives.c
@@ -136,7 +136,7 @@ tar_filenamenode_queue_pop(struct filenamenode_queue *queue,
                            struct fileinlist *node)
 {
   tar_pool_free(node);
-  *queue->tail = *tail_prev;
+  queue->tail = tail_prev;
   *tail_prev = NULL;
 }
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/dpkg.git