[Reproducible-commits] [dpkg] 50/74: dpkg-genchanges: Skip automatic debugging symbol packages

[Mattia Rizzolo]

This is an automated email from the git hooks/post-receive script.

mattia pushed a commit to annotated tag 1.18.8
in repository dpkg.

commit 3426cb9ba2e8d156d3c4a9d014aac87c91d7aa2f
Author: Guillem Jover <guillem at debian.org>
Date:   Tue Jun 7 09:08:48 2016 +0200

    dpkg-genchanges: Skip automatic debugging symbol packages
    
    This is quite ugly as we are hardcoding a package name pattern here,
    which as of now is distribution-specific. For the current automatic
    debug package implementation, these contain an Auto-Built-Package
    field, only present in the generated DEBIAN/control file, because
    they do not exist in the debian/control file. We should eventually
    detect that field and store it in the debian/files list file, and
    then ignore the warning from dpkg-genchanges, but for now we'll just
    quiesce the warning as it avoids unnecessarily confusing people
    reading the output.
---
 debian/changelog           | 2 ++
 scripts/dpkg-genchanges.pl | 4 ++++
 2 files changed, 6 insertions(+)

diff --git a/debian/changelog b/debian/changelog
index f472c5a..3842d1b 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -42,6 +42,8 @@ dpkg (1.18.8) UNRELEASED; urgency=medium
   * Use architecture «all» as part of the .changes filename when building
     architecture independent binaries and no architecture dependent binaries.
     Closes: #826161
+  * Do not emit warnings from dpkg-genchanges for automatic debug symbol
+    packages that are not found in debian/control.
   * Perl modules:
     - Use warnings::warnif() instead of carp() for deprecated warnings.
     - Add new format_range() method and deprecate dpkg() and rfc822() methods
diff --git a/scripts/dpkg-genchanges.pl b/scripts/dpkg-genchanges.pl
index 3ac1dbd..640e9fd 100755
--- a/scripts/dpkg-genchanges.pl
+++ b/scripts/dpkg-genchanges.pl
@@ -401,6 +401,10 @@ if ($changesdescription) {
 
 for my $p (keys %p2f) {
     if (not defined $control->get_pkg_by_name($p)) {
+        # XXX: Skip automatic debugging symbol packages. We should not be
+        # hardcoding packages names here, as this is distribution-specific.
+        # Instead we should use the Auto-Built-Package field.
+        next if $p =~ m/-dbgsym$/;
         warning(g_('package %s listed in files list but not in control info'), $p);
         next;
     }

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/dpkg.git