[Reproducible-commits] [strip-nondeterminism] 01/02: Improve readability in PNG handler by not including IEND detection in "else"

Chris Lamb chris at chris-lamb.co.uk
Mon Jul 18 16:22:15 UTC 2016


This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository strip-nondeterminism.

commit 1cf5dbef41598485275aaa2b2348b0b03190bc15
Author: Chris Lamb <lamby at debian.org>
Date:   Mon Jul 18 18:06:18 2016 +0200

    Improve readability in PNG handler by not including IEND detection in "else"
---
 lib/File/StripNondeterminism/handlers/png.pm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/File/StripNondeterminism/handlers/png.pm b/lib/File/StripNondeterminism/handlers/png.pm
index 4b92047..54ee016 100644
--- a/lib/File/StripNondeterminism/handlers/png.pm
+++ b/lib/File/StripNondeterminism/handlers/png.pm
@@ -72,11 +72,11 @@ sub normalize {
 							gmtime($canonical_time))) if defined($canonical_time);
 		} else {
 			print $tempfile $header . $data;
-
-			last if $type eq 'IEND'; # Stop processing immediately, in case
-						 # there's garbage after the PNG datastream.
-						 # (see https://bugs.debian.org/802057)
 		}
+
+		# Stop processing immediately in case there's garbage after the
+		# PNG datastream. (https://bugs.debian.org/802057)
+		last if $type eq 'IEND';
 	}
 
 	# Copy through trailing garbage.  Conformant PNG files don't have trailing

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/strip-nondeterminism.git



More information about the Reproducible-commits mailing list