[strip-nondeterminism] 03/03: handlers/{jar, png, zip}: Ensure subroutines end with return statement.

Chris Lamb chris at chris-lamb.co.uk
Sat Sep 3 16:30:34 UTC 2016


This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository strip-nondeterminism.

commit 94aa2047aa64ea1e37450e6b4569cb9552890168
Author: Chris Lamb <lamby at debian.org>
Date:   Sat Sep 3 17:28:22 2016 +0100

    handlers/{jar,png,zip}: Ensure subroutines end with return statement.
    
    Signed-off-by: Chris Lamb <lamby at debian.org>
---
 lib/File/StripNondeterminism/handlers/jar.pm | 2 ++
 lib/File/StripNondeterminism/handlers/png.pm | 2 ++
 lib/File/StripNondeterminism/handlers/zip.pm | 2 ++
 3 files changed, 6 insertions(+)

diff --git a/lib/File/StripNondeterminism/handlers/jar.pm b/lib/File/StripNondeterminism/handlers/jar.pm
index bae962f..2db4a24 100644
--- a/lib/File/StripNondeterminism/handlers/jar.pm
+++ b/lib/File/StripNondeterminism/handlers/jar.pm
@@ -87,6 +87,8 @@ sub _jar_normalize_member {
 	} elsif ($member->fileName() =~ /\.jar$/) {
 		File::StripNondeterminism::handlers::zip::normalize_member($member, \&normalize);
 	}
+
+	return 1;
 }
 
 sub _jar_archive_filter {
diff --git a/lib/File/StripNondeterminism/handlers/png.pm b/lib/File/StripNondeterminism/handlers/png.pm
index 8af0c53..5bd1942 100644
--- a/lib/File/StripNondeterminism/handlers/png.pm
+++ b/lib/File/StripNondeterminism/handlers/png.pm
@@ -63,6 +63,8 @@ sub normalize {
 	}
 
 	close $fh;
+
+	return 1;
 }
 
 sub _normalize {
diff --git a/lib/File/StripNondeterminism/handlers/zip.pm b/lib/File/StripNondeterminism/handlers/zip.pm
index 7f2dd6f..12f8613 100644
--- a/lib/File/StripNondeterminism/handlers/zip.pm
+++ b/lib/File/StripNondeterminism/handlers/zip.pm
@@ -64,6 +64,8 @@ sub normalize_member {
 	}
 
 	unlink($filename);
+
+	return 1;
 }
 
 use constant {

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/strip-nondeterminism.git



More information about the Reproducible-commits mailing list