[reprotest] 01/01: Don't use dangerous default value [] as function argument.

Chris Lamb chris at chris-lamb.co.uk
Wed Sep 28 22:07:07 UTC 2016


This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository reprotest.

commit 81fb6636d7a5e4d25c70f38975c51481d9a9ee9d
Author: Chris Lamb <lamby at debian.org>
Date:   Wed Sep 28 23:01:46 2016 +0100

    Don't use dangerous default value [] as function argument.
---
 reprotest/__init__.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/reprotest/__init__.py b/reprotest/__init__.py
index 17fccbe..1f60f05 100644
--- a/reprotest/__init__.py
+++ b/reprotest/__init__.py
@@ -334,7 +334,9 @@ def build(script, source_root, dist_root, artifact_pattern, testbed, artifact_st
 
 
 def check(build_command, artifact_pattern, virtual_server_args, source_root,
-          no_clean_on_error=False, variations=VARIATIONS, diffoscope_args=[]):
+          no_clean_on_error=False, variations=VARIATIONS, diffoscope_args=None):
+    if diffoscope_args is None:
+        diffoscope_args = []
     # print(virtual_server_args)
     with tempfile.TemporaryDirectory() as temp_dir, \
          start_testbed(virtual_server_args, temp_dir, no_clean_on_error) as testbed:

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/reprotest.git



More information about the Reproducible-commits mailing list