[buildinfo.debian.net] 01/01: Prevent JOIN from returning too many results.

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository buildinfo.debian.net.

commit 04f2f56c79c4a17ad0904c8f10caff7928d4556e
Author: Chris Lamb <lamby at debian.org>
Date:   Tue Nov 8 14:24:16 2016 +0000

    Prevent JOIN from returning too many results.
    
    Signed-off-by: Chris Lamb <lamby at debian.org>
---
 bidb/packages/views.py | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/bidb/packages/views.py b/bidb/packages/views.py
index 9615d48..a7b2569 100644
--- a/bidb/packages/views.py
+++ b/bidb/packages/views.py
@@ -1,3 +1,4 @@
+from django.http import Http404
 from django.shortcuts import render, get_object_or_404
 
 from bidb.utils.itertools import groupby
@@ -37,11 +38,10 @@ def source(request, name):
     })
 
 def source_version(request, name, version):
-    source = get_object_or_404(
-        Source,
-        name=name,
-        buildinfos__version=version,
-    )
+    source = get_object_or_404(Source, name=name)
+
+    if not source.buildinfos.filter(version=version).exists():
+        raise Http404()
 
     buildinfos_by_arch = groupby(
         source.buildinfos.order_by('architecture__name'),

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/buildinfo.debian.net.git