[reprotest] 01/08: Stop advertising variations that we're not actually varying. WTF.

[Ximin Luo]

This is an automated email from the git hooks/post-receive script.

infinity0 pushed a commit to branch master
in repository reprotest.

commit 4ccbb64e57993c2208237da3aa0b7ab4775cda16
Author: Ximin Luo <infinity0 at debian.org>
Date:   Thu Dec 1 19:32:29 2016 +0100

    Stop advertising variations that we're not actually varying. WTF.
---
 debian/changelog      |  7 +++++++
 reprotest/__init__.py | 37 +++++++++++++++++++++----------------
 2 files changed, 28 insertions(+), 16 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index ab51ad8..0421733 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+reprotest (0.5) UNRELEASED; urgency=medium
+
+  * Stop advertising variations that we're not actually varying.
+    That is: domain_host, shell, user_group.
+
+ -- Ximin Luo <infinity0 at debian.org>  Thu, 01 Dec 2016 19:31:55 +0100
+
 reprotest (0.4) unstable; urgency=medium
 
   * Document virtual servers and caveats better.
diff --git a/reprotest/__init__.py b/reprotest/__init__.py
index f7c7fb7..c894222 100644
--- a/reprotest/__init__.py
+++ b/reprotest/__init__.py
@@ -175,9 +175,9 @@ def captures_environment(script, env, tree, testbed):
     yield script, Pair(env.control, new_env), tree
 
 # TODO: this requires superuser privileges.
- at _contextlib.contextmanager
-def domain_host(script, env, tree, testbed):
-    yield script, env, tree
+# @_contextlib.contextmanager
+# def domain_host(script, env, tree, testbed):
+#     yield script, env, tree
 
 @_contextlib.contextmanager
 def fileordering(script, env, tree, testbed):
@@ -269,9 +269,9 @@ def path(script, env, tree, testbed):
 
 # This doesn't require superuser privileges, but the chsh command
 # affects all user shells, which would be bad.
- at _contextlib.contextmanager
-def shell(script, env, tree, testbed):
-    yield script, env, tree
+# @_contextlib.contextmanager
+# def shell(script, env, tree, testbed):
+#     yield script, env, tree
 
 @_contextlib.contextmanager
 def timezone(script, env, tree, testbed):
@@ -294,22 +294,27 @@ def umask(script, env, tree, testbed):
     yield Pair(new_control, new_experiment), env, tree
 
 # TODO: This requires superuser privileges.
- at _contextlib.contextmanager
-def user_group(script, env, tree, testbed):
-    yield script, env, tree
+# @_contextlib.contextmanager
+# def user_group(script, env, tree, testbed):
+#     yield script, env, tree
 
 
 # The order of the variations *is* important, because the command to
 # be executed in the container needs to be built from the inside out.
 VARIATIONS = types.MappingProxyType(collections.OrderedDict([
     ('captures_environment', captures_environment),
-    # 'cpu': cpu,
-    ('domain_host', domain_host), ('fileordering', fileordering),
-    ('home', home), ('kernel', kernel), ('locales', locales),
-    # 'namespace': namespace,
-    ('path', path), ('shell', shell),
-    ('timezone', timezone), ('umask', umask),
-    ('user_group', user_group)
+    # ('cpu', cpu),
+    # ('domain_host', domain_host),
+    ('fileordering', fileordering),
+    ('home', home),
+    ('kernel', kernel),
+    ('locales', locales),
+    # ('namespace', namespace),
+    ('path', path),
+    # ('shell', shell),
+    ('timezone', timezone),
+    ('umask', umask),
+    # ('user_group', user_group)
 ]))
 
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/reprotest.git