[reprotest] 01/01: Set NO_FAKE_STAT for faketime. Hours wasted b/c this wasn't mentioned in the manpage

Ximin Luo infinity0 at debian.org
Thu Dec 8 22:55:35 UTC 2016


This is an automated email from the git hooks/post-receive script.

infinity0 pushed a commit to branch master
in repository reprotest.

commit 7308e4e0ca03bfbc2a20c90514b9afa28b9e5f2d
Author: Ximin Luo <infinity0 at debian.org>
Date:   Thu Dec 8 23:54:07 2016 +0100

    Set NO_FAKE_STAT for faketime. Hours wasted b/c this wasn't mentioned in the manpage
---
 reprotest/__init__.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/reprotest/__init__.py b/reprotest/__init__.py
index 4972d08..56b77a0 100644
--- a/reprotest/__init__.py
+++ b/reprotest/__init__.py
@@ -318,7 +318,11 @@ def faketime(script, env, tree, source_root):
     t = int(max(filemtimes, default=time.time()))
     settime = _shell_ast.SimpleCommand.make('faketime', '@%s'%t)
     new_experiment = script.experiment.append_command(settime)
-    return Pair(script.control, new_experiment), env, tree
+    # faketime's manpages are stupidly misleading; it also modifies file timestamps.
+    # this is only mentioned in the README. we do not want this, it really really
+    # messes with GNU make and other buildsystems that look at timestamps.
+    new_experiment_env = add(env.experiment, 'NO_FAKE_STAT', '1')
+    return Pair(script.control, new_experiment), Pair(env.control, new_experiment_env), tree
 
 def umask(script, env, tree, *args):
     new_control = script.control.append_setup_exec('umask', '0022')

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/reprotest.git



More information about the Reproducible-commits mailing list