[dpkg] 106/200: dpkg-gencontrol: Stop emitting Built-For-Profiles

Ximin Luo infinity0 at debian.org
Wed Apr 5 15:17:25 UTC 2017


This is an automated email from the git hooks/post-receive script.

infinity0 pushed a commit to branch master
in repository dpkg.

commit cd9f688ca4bfd49e6574e2842dbd514459e84569
Author: Guillem Jover <guillem at debian.org>
Date:   Sun Jan 22 16:16:19 2017 +0100

    dpkg-gencontrol: Stop emitting Built-For-Profiles
    
    The information is already provided in .buildinfo files, and including
    it in the binary packages makes them unreproducible even when the
    profile used would not alter its contents.
    
    Closes: #831524
---
 debian/changelog           | 4 ++++
 man/deb-control.man        | 8 +++++---
 scripts/dpkg-gencontrol.pl | 2 --
 3 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 3f83250..be9f57c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,6 +1,10 @@
 dpkg (1.18.19) UNRELEASED; urgency=medium
 
   [ Guillem Jover ]
+  * Stop emitting Built-For-Profiles from dpkg-gencontrol. The information
+    is already provided in .buildinfo files, and including it in the binary
+    packages makes them unreproducible even when the profile used would not
+    alter its contents. Closes: #831524
   * Portability:
     - On GNU/Hurd try to use the new process executable name attribute from
       libps, to properly match on start-stop-daemon --exec.
diff --git a/man/deb-control.man b/man/deb-control.man
index c6c49b3..ff1ebc2 100644
--- a/man/deb-control.man
+++ b/man/deb-control.man
@@ -317,9 +317,11 @@ refuse to accept an upload which declares a
 relationship which cannot be satisfied within the archive.
 .
 .TP
-.BI Built\-For\-Profiles: " profile-list"
-This field specifies a whitespace separated list of build profiles that this
-binary packages was built with.
+.BI Built\-For\-Profiles: " profile-list (obsolete)"
+This field used to specify a whitespace separated list of build profiles that
+this binary packages was built with (since dpkg 1.17.2 until 1.18.18).
+The information previously found in this field can now be found in the
+\fB.buildinfo\fP file, which supersedes it.
 .
 .SH EXAMPLE
 .\" .RS
diff --git a/scripts/dpkg-gencontrol.pl b/scripts/dpkg-gencontrol.pl
index dbc6b4f..94d6d2d 100755
--- a/scripts/dpkg-gencontrol.pl
+++ b/scripts/dpkg-gencontrol.pl
@@ -299,8 +299,6 @@ foreach my $field (field_list_pkg_dep()) {
     }
 }
 
-$fields->{'Built-For-Profiles'} = join ' ', get_build_profiles();
-
 for my $f (qw(Package Version Architecture)) {
     error(g_('missing information for output field %s'), $f)
         unless defined $fields->{$f};

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/dpkg.git



More information about the Reproducible-commits mailing list