[reprotest] 01/01: Don't output spurious warnings in tests

Ximin Luo infinity0 at debian.org
Tue Oct 3 17:08:30 UTC 2017


This is an automated email from the git hooks/post-receive script.

infinity0 pushed a commit to branch master
in repository reprotest.

commit 77f4195d0bc090f3c0fccfd1de461dbacacc08d7
Author: Ximin Luo <infinity0 at debian.org>
Date:   Tue Oct 3 19:08:03 2017 +0200

    Don't output spurious warnings in tests
---
 reprotest/__init__.py   | 2 +-
 tests/test_reprotest.py | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/reprotest/__init__.py b/reprotest/__init__.py
index 8e77fa3..6e73ed5 100644
--- a/reprotest/__init__.py
+++ b/reprotest/__init__.py
@@ -683,7 +683,7 @@ def run(argv, dry_run=None):
     build_variations = Variations.of(*specs, verbosity=verbosity)
 
     # Warn about missing programs
-    if virtual_server_args[0] == "null":
+    if virtual_server_args[0] == "null" and not dry_run:
         missing = [(var, tool_missing(action))
             for spec in specs
             for var, vary, action in spec.actions()
diff --git a/tests/test_reprotest.py b/tests/test_reprotest.py
index 80635eb..51cc9dd 100644
--- a/tests/test_reprotest.py
+++ b/tests/test_reprotest.py
@@ -98,8 +98,6 @@ def test_command_lines():
     assert testbed_args.virtual_server_args == ['schroot', 'unstable-amd64-sbuild']
     _, testbed_args, _ = check_command_line(". -- schroot unstable-amd64-sbuild".split(), 0)
     assert testbed_args.virtual_server_args == ['schroot', 'unstable-amd64-sbuild']
-    _, testbed_args, _ = check_command_line("auto . schroot unstable-amd64-sbuild".split(), 0)
-    assert testbed_args.virtual_server_args == ['schroot', 'unstable-amd64-sbuild']
 
 # TODO: don't call it if we don't have debian/, e.g. for other distros
 def test_debian_build(virtual_server):

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/reprotest.git



More information about the Reproducible-commits mailing list