[dpkg] 40/192: test: Enable perlcritic Documentation::RequirePodSections

[Ximin Luo]

This is an automated email from the git hooks/post-receive script.

infinity0 pushed a commit to branch pu/reproducible_builds
in repository dpkg.

commit 27d8ebdbe3e106d2d16c37e9e3e4271308aab17a
Author: Guillem Jover <guillem at debian.org>
Date:   Thu May 18 00:00:38 2017 +0200

    test: Enable perlcritic Documentation::RequirePodSections
    
    Declare the minimum required POD sections.
---
 debian/changelog      | 3 ++-
 t/critic.t            | 1 +
 t/critic/perlcriticrc | 7 ++++---
 3 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index d7dbd39..393735b 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -10,7 +10,8 @@ dpkg (1.19.0) UNRELEASED; urgency=medium
     - Do not override the default DEPENDENCIES for libdpkg, extend it instead.
     - Install perl man pages in section 3perl.
   * Test suite:
-    - Enable perlcritic Miscellanea::ProhibitTies.
+    - Enable perlcritic Documentation::RequirePodSections and
+      Miscellanea::ProhibitTies.
 
  -- Guillem Jover <guillem at debian.org>  Thu, 18 May 2017 05:27:31 +0200
 
diff --git a/t/critic.t b/t/critic.t
index d5eab8d..7cc4c9e 100644
--- a/t/critic.t
+++ b/t/critic.t
@@ -51,6 +51,7 @@ my @policies = qw(
     ControlStructures::ProhibitNegativeExpressionsInUnlessAndUntilConditions
     ControlStructures::ProhibitUntilBlocks
     Documentation::RequirePackageMatchesPodName
+    Documentation::RequirePodSections
     InputOutput::ProhibitBarewordFileHandles
     InputOutput::ProhibitInteractiveTest
     InputOutput::ProhibitJoinedReadline
diff --git a/t/critic/perlcriticrc b/t/critic/perlcriticrc
index 8dabccd..308cc04 100644
--- a/t/critic/perlcriticrc
+++ b/t/critic/perlcriticrc
@@ -7,6 +7,10 @@ program-extensions = .pl .t
 ## Tune tests
 ##
 
+[Documentation::RequirePodSections]
+lib_sections = NAME | DESCRIPTION | CHANGES
+script_sections = NAME | SYNOPSIS | DESCRIPTION
+
 [RegularExpressions::ProhibitUnusualDelimiters]
 allow_all_brackets = 1
 
@@ -39,9 +43,6 @@ allow_if_string_contains_single_quote = 1
 # FIXME: Bogus check.
 [-Documentation::RequirePodLinksIncludeText]
 
-# TODO: Standardize sections, but the ones from this are not usable.
-[-Documentation::RequirePodSections]
-
 # Too many false positives.
 [-CodeLayout::RequireTidyCode]
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/dpkg.git