[dpkg] 83/192: t: Rename FIXME to BUG
Ximin Luo
infinity0 at debian.org
Tue Oct 17 11:04:03 UTC 2017
This is an automated email from the git hooks/post-receive script.
infinity0 pushed a commit to branch pu/reproducible_builds
in repository dpkg.
commit 38ec57a5ac6e82f3eb8835dd35b2b9b2821853b7
Author: Guillem Jover <guillem at debian.org>
Date: Fri Jul 14 02:02:30 2017 +0200
t: Rename FIXME to BUG
This is not something that we can easily fix, those are all upstream
problems.
---
t/critic/perlcriticrc | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/t/critic/perlcriticrc b/t/critic/perlcriticrc
index 30b8205..990462f 100644
--- a/t/critic/perlcriticrc
+++ b/t/critic/perlcriticrc
@@ -28,19 +28,19 @@ allow_if_string_contains_single_quote = 1
## Disable tests
##
-# Complex is not always bad.
+# Here complex is meant as long, but long is not necessarily complex.
[-BuiltinFunctions::ProhibitComplexMappings]
# Needed when generating code.
[-BuiltinFunctions::ProhibitStringyEval]
-# FIXME: Bogus check.
+# BUG: Bogus check.
[-Documentation::PodSpelling]
# While this might be good for performance, it is bad for keeping docs updated.
[-Documentation::RequirePodAtEnd]
-# FIXME: Bogus check.
+# BUG: Bogus check.
[-Documentation::RequirePodLinksIncludeText]
# Too many false positives.
@@ -58,7 +58,7 @@ allow_if_string_contains_single_quote = 1
# These are fine, usually as long as they are not double negations.
[-ControlStructures::ProhibitUnlessBlocks]
-# FIXME: Too many false positives.
+# BUG: Too many false positives.
[-ControlStructures::ProhibitUnreachableCode]
# TODO: Check it out, add new Dpkg::Program module?
@@ -70,10 +70,10 @@ allow_if_string_contains_single_quote = 1
# TODO: Maybe, some of these are part of the public/current API.
[-Modules::ProhibitAutomaticExportation]
-# Complex is not always bad.
+# Here complex is meant as long, but long is not necessarily complex.
[-Modules::ProhibitExcessMainComplexity]
-# FIXME: Too many false positives; non-modules all trigger.
+# BUG: Too many false positives; non-modules all trigger.
[-Modules::RequireVersionVar]
# These are fine.
@@ -104,7 +104,7 @@ allow_if_string_contains_single_quote = 1
# Readers need to know perl.
[-Variables::RequireInitializationForLocalVars]
-# FIXME: Too many false positives; on ::main and for $ENV, $SIG, $?, $a, $b.
+# BUG: Too many false positives; on ::main and for $ENV, $SIG, $?, $a, $b.
[-Variables::RequireLocalizedPunctuationVars]
# Readonly is not a core module.
@@ -125,5 +125,5 @@ allow_if_string_contains_single_quote = 1
# TODO: Check it out, some magic numbers are fine, octals for example.
[-ValuesAndExpressions::ProhibitMagicNumbers]
-# FIXME: False positives on long hex numbers, even when separated.
+# BUG: False positives on long hex numbers, even when separated.
[-ValuesAndExpressions::RequireNumberSeparators]
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/dpkg.git
More information about the Reproducible-commits
mailing list