[dpkg] 164/192: Dpkg::Control::HashCore: Do not use an intermediate variable in STORE method

[Ximin Luo]

This is an automated email from the git hooks/post-receive script.

infinity0 pushed a commit to branch pu/reproducible_builds
in repository dpkg.

commit 63958db6f8a0816539ad98b419775ae1ae00105c
Author: Guillem Jover <guillem at debian.org>
Date:   Tue Sep 26 05:09:43 2017 +0200

    Dpkg::Control::HashCore: Do not use an intermediate variable in STORE method
---
 debian/changelog                 | 2 ++
 scripts/Dpkg/Control/HashCore.pm | 3 +--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index e5c7156..0079340 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -90,6 +90,8 @@ dpkg (1.19.0) UNRELEASED; urgency=medium
       when parsing control files in Dpkg::Control::HashCore.
     - Merge build flag methods into a single _add_build_flags private method
       in Dpkg::Vendor::Debian.
+    - Do not use an intermediate variable in Dpkg::Control::HashCore::Tie
+      STORE method.
   * Documentation:
     - Document currently accepted syntax for changelogs in deb-changelog(5).
       Closes: #858579
diff --git a/scripts/Dpkg/Control/HashCore.pm b/scripts/Dpkg/Control/HashCore.pm
index 17d8ed7..91b279d 100644
--- a/scripts/Dpkg/Control/HashCore.pm
+++ b/scripts/Dpkg/Control/HashCore.pm
@@ -485,10 +485,9 @@ sub FETCH {
 
 sub STORE {
     my ($self, $key, $value) = @_;
-    my $parent = $self->[1];
     $key = lc($key);
     if (not exists $self->[0]->{$key}) {
-	push @{$parent->{in_order}}, field_capitalize($key);
+        push @{$self->[1]->{in_order}}, field_capitalize($key);
     }
     $self->[0]->{$key} = $value;
 }

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/dpkg.git