[Secure-testing-team] Bug#758220: hotkeys: segmentation fault in sound module

[Dmitriy Dyomin]

Package: hotkeys
Version: 0.5.7.4-0.3+b1
Severity: normal
Tags: security

Hotkeys daemon failes to run when ALSA soundcard is configured in hotkeys.conf.

....
### ALSA card
ALSAcard=default
### List of ALSA control names, separated by "|"
ALSAcontrols=Master
....

Kernel log shows that it is a segmentation fault:

hotkeys[11591]: segfault at 20 ip 00007f3e57871ab1 sp 00007fff929e1990 error 4
in libasound.so.2.0.0[7f3e57828000+f0000]

Examining function getConfig in src/conf.c, I've found that the value of
automatic variable DBT data is returned. So, in successive calls of getConfig()
(for alsacard and alsacontrols in hotkeys.c) aslacard obtains incorrect value
prior to configALSA() call.

A possible solution may be to rewrite getConfig() data for not to use pointers
to automatic variables as return values.



-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.14.5 (SMP w/8 CPU cores)
Locale: LANG=ru_RU.UTF-8, LC_CTYPE=ru_RU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages hotkeys depends on:
ii  libasound2          1.0.28-1
ii  libatk1.0-0         2.12.0-1
ii  libc6               2.19-7
ii  libcairo2           1.12.16-2
ii  libdb5.1            5.1.29-7
ii  libfontconfig1      2.11.0-5
ii  libfreetype6        2.5.2-1.1
ii  libgdk-pixbuf2.0-0  2.30.7-1
ii  libglib2.0-0        2.40.0-4
ii  libgtk2.0-0         2.24.24-1
ii  libpango1.0-0       1.36.3-1
ii  libx11-6            2:1.6.2-2
ii  libxext6            2:1.3.2-1
ii  libxinerama1        2:1.1.3-1
ii  libxml2             2.9.1+dfsg1-4
ii  libxmu6             2:1.1.2-1
ii  libxosd2            2.2.14-2.1
ii  libxrandr2          2:1.4.2-1
ii  libxrender1         1:0.9.8-1

hotkeys recommends no packages.

hotkeys suggests no packages.

-- no debconf information
-------------- next part --------------
############################################################
# Global configuration for hotkeys                         #
############################################################

# These are the default values.
# A line starting with # is a comment.

### Specify the default keyboard  (without the .def extension) so you
### don't need to specify -t every time
Kbd=lenovo
# CDROM=/dev/cdrom

### ALSA card
ALSAcard=default
### List of ALSA control names, separated by "|"
ALSAcontrols=Master

# PrevTrack=xmms --rew
# Play=xmms --play-pause
# Stop=xmms --stop
# Pause=xmms --pause
# NextTrack=xmms --fwd
# Rewind=

# WebBrowser=mozilla
# Email=mozilla -mail
# Calculator=xcalc
# FileManager=gmc
# MyComputer=gmc
# MyDocuments=gmc
# Favorites=gnome-moz-remote --remote=openBookmarks
# Transfer=gtp
# Record=grecord
# Shell=xterm -rv
# ScreenSaver=xscreensaver-command -activate
# NewsReader=mozilla -news
# Communities=mozilla -remote 'openURL(http://slashdot.org)'
# Search=mozilla -remote 'openURL(http://google.com)'
# Idea=mozilla -remote 'openURL(http://sourceforge.net)'
# Shopping=mozilla -remote 'openURL(http://thinkgeek.com)'
# Go=mozilla -remote 'openURL(http://linux.com)'
# Print=lpr
# Rotate=

# osd_font=-arphic-ar pl kaitim big5-bold-i-normal--0-250-0-0-c-0-*-*
### For the color, you can either use the strings in /etc/X11/rgb.txt,
### or use the RGB syntax #RRGGBB, e.g. ##A086FF
# osd_color=LawnGreen
# osd_timeout=3
### osd_position is either 'top' or 'bottom'
# osd_position=bottom
# osd_offset=25