[Simple-cdd-devel] environment/config variable handling

[Vagrant Cascadian]

On 2015-02-27, Vagrant Cascadian wrote:
> On 2015-02-26, Enrico Zini <enrico at enricozini.org> wrote:
>> On Sun, Feb 22, 2015 at 10:58:31AM -0800, Vagrant Cascadian wrote:
>>
>>> Just did a quick build and seems to work ok, minus the http_proxy issue.

Fixed the http_proxy issue by pasing env to run_command:

- retval = run_command("wget {}".format(url), args, logfd=logfd)
+ retval = run_command("wget {}".format(url), args, logfd=logfd, env=wget_env)

It should now work when there's no http_proxy set, when it's set in both
the environment and the conf, when it's set when only the conf is set,
and when it's set only in the conf.

Committed and pushed, works for me!


> A smaller issue revealed is more of a question: should profiles/*.conf
> should override environment variables? I need to verify how it works in
> the original code to see if it's a change in behavior or not.

From a quick glance, I think this is not a change in behavior, so while
sometimes confusing, I don't think it's worth changing.


live well,
  vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/simple-cdd-devel/attachments/20150227/d67df282/attachment.sig>