[Simple-cdd-devel] Bug#861198: Shutting down public FTP services

[Enrico Zini]

On Mon, May 15, 2017 at 10:18:22AM -0700, Vagrant Cascadian wrote:

>     File "/home/vagrant/simple-cdd/simple_cdd/utils.py", line 207, in verify_file
>       raise Fail("Invalid checksum for {}: expected {}, got {}", absname, hashsum, hasher.hexdigest())
>   simple_cdd.exceptions.Fail: <unprintable Fail object>
>   
>   During handling of the above exception, another exception occurred:
>   
>   Traceback (most recent call last):
>     File "/home/vagrant/simple-cdd/simple_cdd/log.py", line 85, in emit
>       record.message = record.getMessage()
>     File "/usr/lib/python3.5/logging/__init__.py", line 331, in getMessage
>       msg = msg % self.args
>   TypeError: not all arguments converted during string formatting

Fail used %-formatting internally, but it was sometimes called with
printf-style format strings and sometimes with string.format style
format strings. I'm attaching a patch that unifies everything to
string.format-style strings.


Enrico

-- 
GPG key: 4096R/634F4BD1E7AD5568 2009-05-08 Enrico Zini <enrico at enricozini.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Standardised-Fail-behaviour-on-string.format.patch
Type: text/x-diff
Size: 8281 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/simple-cdd-devel/attachments/20170515/e154c5a3/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/simple-cdd-devel/attachments/20170515/e154c5a3/attachment.sig>